zeckson / 125753-yeticave-1 Goto Github PK
View Code? Open in Web Editor NEWЕвгений Щепотьев
Евгений Щепотьев
Remove and add docker-compose.yml
Empty is bad practice due to cast everything to everything
http://php.net/manual/en/function.empty.php
Есть ещё ошибки при отправке почты в редких случаях, но это не совсем про базовый PHP, так что не надо делать: https://yadi.sk/i/vYPWo0rnt_fQ2w
На странице категории заголовок остается "заглавная". Не критично.
на странице лота не делаем точно, https://yadi.sk/i/N2gWqXKzhnxb9Q
возможно, где-то ещё...
вместо DROP DATABASE yeticave; следовало написать DROP DATABASE IF EXISTS yeticave;
Fatal error: Uncaught TypeError: Return value of login() must be of the type array, null returned in /Users/ilia.kondrashov/Downloads/project-40819/src/user_queries.php:65 Stack trace: #0 /Users/ilia.kondrashov/Downloads/project-40819/login.php(30): login(Object(mysqli), '[email protected]...', 'qqq') #1 {main} thrown in /Users/ilia.kondrashov/Downloads/project-40819/src/user_queries.php on line 65
В ТЗ есть условия на вывода блока добавления ставок, но не на цену и историю ставок.
There is finishing indicator on time timer--finishing
that is not used currently
https://yadi.sk/i/LZkuW8DlVquCXA нет проверки на то, что число в значении нашего параметра?
константы не подключаем, например, в lot.php, от этого ошибка: https://yadi.sk/i/XdcrdBx1MRqn4Q
Не во всех файлах я вижу в начале declare(strict_types=1);, а без этого жесткая типизация во-многом теряет смысл.
в таблицу категорий можно было бы добавить поле alias или url, тогда бы могли генерить ссылки /lot_list.php?category=boots вместо /lot_list.php?category=2, а тут и до ЧПУ не долго)
http://0.0.0.0:3000/search.php?query=scoop
Warning: mysqli_stmt_bind_param() expects parameter 1 to be mysqli_stmt, boolean given in /Users/ilia.kondrashov/Downloads/project-40819/src/utils/db.php on line 35
Warning: mysqli_stmt_execute() expects parameter 1 to be mysqli_stmt, boolean given in /Users/ilia.kondrashov/Downloads/project-40819/src/utils/db.php on line 38
Fatal error: Failed SQL-query: "SELECT lot.id, lot.name, start_price, description, bid_step, lot.created_at, lot.closed_at, lot.author_id, IFNULL(MAX(bid.amount), start_price) AS price, image_url AS image, category.name AS category, count(bid.id) AS bids_count FROM lots lot LEFT JOIN categories category ON lot.category_id = category.id LEFT JOIN bids bid ON lot.id = bid.lot_id WHERE TIMESTAMP('2018-10-15 17:42:38') < lot.closed_at AND MATCH(lot.name, lot.description) AGAINST (?) GROUP BY lot.id ORDER BY lot.created_at DESC" with error: Can't find FULLTEXT index matching the column list in /Users/ilia.kondrashov/Downloads/project-40819/src/utils/db.php on line 42
For all funs return array
For get single funs return ?array
Предлагаю убрать слово "Стартовая"
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.