zeelot / kohana-media Goto Github PK

Hello,

I have so many js files in my project and the list grows.

I want to use head.js but I did not manage it, will you please make an example for this?

http://headjs.com/

thanks.

As a test, I grabbed Kohana 3.2 and this kohana-media module (dev 1.2)
I created my own module with just a simple css file and in the application folder I created another simple css file.
In the default welcome controller I called up a view which has minimal html with those 2 css files.

The first request (with empty DOCROOT/media folder) would only load either 1 of those 2 css files, the other has internal server error. It seems to randomly load one but not the other. (re-test: clear media folder and refresh again)

Firebug shows that the error comes from where it creates the cache folder:
https://github.com/Zeelot/kohana-media/blob/dev/1.2.x/classes/controller/media.php#L36-40

The media module doesn't appear to send any 304 headers, therefore it doesn't cache anything properly at the browser level. Is this intentional, or just plain broken?

Would you accept a patch for composer.json support?

How would you recommend one go about serving media files (css, js, and images) from within a vendor directory? Specifically, I've got vendor at the top level (DOCROOT), where it's installed by Composer. I've got a hack working with the following in the Media controller:

    if ( ! $cfs_file)
    {
        echo $cfs_file = DOCROOT.'vendor'.DIRECTORY_SEPARATOR.$filepath;
    }

but that does seem pretty hacky. Any suggestions?

Thanks! :-)