Comments (5)
Really cool to see the pre-commit hook btw!
from kube-score.
Additional motivation: I use tools like chart-testing and this tool uses a config file of its own, for instance. Would be neat if this tool could follow a similar usage pattern.
from kube-score.
A configuration file has been discussed before (#231, #384, and most recently in #468), and it's still a bit unclear to me what problems we would solve by adding a third way of configuring kube-score (--flags, and in-object annotations).
Do you have an example of what you would like to configure with the help of a configuration file that's hard to configure with flags or annotations today?
from kube-score.
Hey @zegl, so --flags
have to be parsed out alongside supplied helm charts in the pre-commit script. So in my hook's example readme,
hooks:
- id: kube-score
args:
- chart1-dir
- chart2-dir
- ...
it's relatively easy to supply and parse out Helm chart directories as args, but I think to configure kube-score alongside those args, it would be pretty difficult; especially with a variable number of potential helm chart directories and config flags.
from kube-score.
Again, following the pattern of chart-testing from the Helm project, I've used config files like the following.
# helm chart locations to score, say
chart-dirs:
- apps/helm-apps
- helm
excluded-charts:
- metrics-server
# chart-testing configuration options below
check-version-increment: true
lint-conf: .helm-lint.yaml
target-branch: master
remote: origin
validate-maintainers: false
exclude-deprecated: true
so maybe, we tell kube-score where our charts generally live, which charts in those locations to specifically exclude, along with a few kube-score-specific config flags after that. Of course, it doesn't have to be this complex.
Tbh, if it were just possible to stash either kube-score config or helm chart lists in the config, that would help, but following a similar pattern would be neat for engineers using either or both tools in any given project. It may help adoption some as well (e.g. I know I'd use this anywhere I was using chart-testing, and vice versa).
from kube-score.
Related Issues (20)
- how to run kube-score in "report" mode ? returning exit-code 0 regardless of the issues discovered HOT 1
- question: how to ignore init container in multi pod deployment HOT 4
- New Rule: CronJob resource requires Pod restartPolicy set to Never or OnFailure HOT 2
- Feature request: Want optional test annotation into manifest
- kube-score/ignore ignored at pod level inside a statefulset HOT 1
- feature request: topologySpreadConstraints HOT 2
- Please submit a PR to update version in krew-index HOT 1
- amd64 docker images have not been published HOT 5
- Newest release(s) not respecting kube-score/ignore annotations. HOT 3
- Support colored output in Github Actions HOT 5
- Add flag --run-test strings HOT 8
- Documentation on the use of livenessProbe
- Gatekeeper policy compatibility HOT 2
- Facing an issue in kube-score code HOT 1
- Can we set rules to ignore init-Container HOT 2
- API for easier embedding into other applications
- Helm chart is reporting a missing PodDisruptionBudget when replicas count is not defined HOT 2
- Ignoring rule container-resources makes every rule exceptional HOT 4
- Support sidecarContainers HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kube-score.