GithubHelp home page GithubHelp logo

Comments (5)

Sebelino avatar Sebelino commented on June 2, 2024

This appears to be related to fatih/color#132.

I can think of three solutions:

  1. Set color.NoColor = false unconditionally. However, this would mess up output resulting from piping operations.
  2. If colorization of the output is considered a component of the output format, introduce a new value for the --output-format parameter. However, depending on one's needs, this might warrant a combinatorial explosion of supported values for this parameter (human-nocolor, ci-nocolor, sarif-nocolor...).
  3. If colorization is not considered a component of the output format, introduce a --color parameter with the values auto, always and never, similar to how ls --color works. This seems to me to be the most flexible solution, though it requires introducing a new optional parameter.

from kube-score.

zegl avatar zegl commented on June 2, 2024

Hej @Sebelino! 👋

Hmmmm, that's annoying, I would have expected faith/color to be smarter here. I think that I like option 3 the best, maybe in some sort of combination with automatic detection if we're running inside GitHub Actions.

from kube-score.

zegl avatar zegl commented on June 2, 2024

I've pushed a hacky fix with auto coloring support that enables color support by default when running on GitHub Actions. Are you building from source, or should I make a new release so that you can test it?

from kube-score.

Sebelino avatar Sebelino commented on June 2, 2024

Hoy, that was quick! I built it from source and it works beautifully now. Didn't even have to supply the --color flag, although it's still a nice-to-have feature.

Thanks!

image

from kube-score.

zegl avatar zegl commented on June 2, 2024

No problem! :-)

from kube-score.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.