GithubHelp home page GithubHelp logo

zeichen32 / piwikcustomoptout Goto Github PK

View Code? Open in Web Editor NEW
25.0 25.0 10.0 1015 KB

Create your own piwik opt-out iframe css styles

License: GNU General Public License v3.0

PHP 2.46% JavaScript 95.46% CSS 1.57% Twig 0.51%
matomo-plugin

piwikcustomoptout's People

Contributors

comradekingu avatar craue avatar findus23 avatar kghbln avatar sgiehl avatar weblate avatar xmysteriox avatar zeichen32 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

piwikcustomoptout's Issues

messed backend in 0.1.7

2014-06-03_19h53_32
messed backend in 0.1.7
Piwik 2.4B3
FF30
please see attachment

=> other backend sites from piwik/other plugins look fine

Compatibility with Piwik 3

Hi there,

I just noticed an error when using the plugin with the latest Piwik 3.0.0-b3 version in https://github.com/Zeichen32/PiwikCustomOptOut/blob/master/Menu.php#L24

addSettingsItem() should be replaced with addSystemItem()

Here is a guide for migrating plugins to Piwik 3: http://developer.piwik.org/guides/migrate-piwik-2-to-3

You would pretty much only need to update plugin.json to require Piwik 3 as described in the guide and then release a new version.

Haven't checked if there are any other problems re compatibility with Piwik 3

Key "custom_css" for array with keys " ... " does not exist.

Hey,
here is a Problem of mine,
everytime i try to open the Custom OPT out Tab , it shows me this Error.

I tried Clearing the OP Cache and restarting my Webserver but nothing fixed it.

Key "custom_css" for array with keys "idsite, name, main_url, ts_created, ecommerce, sitesearch, sitesearch_keyword_parameters, sitesearch_category_parameters, timezone, currency, exclude_unknown_urls, excluded_ips, excluded_parameters, excluded_user_agents, group, type, keep_url_fragment, timezone_name, currency_name, alias_urls" does not exist. in /html/matomo/plugins/CustomOptOut/templates/index.twig 38 using PHP 7.0.29

URL-Parameter should use &idsite= and not &idSite= (notice the case difference)

In the log i noticed the error "Invalid idSite: '0'" and found following hint in the Piwik forum:
http://forum.piwik.org/read.php?2,115076

In one Posting (from matt, 'May 09, 2014 12:58AM'):
you should use &idsite= and not &idSite= (notice the case difference)
If you saw &idSite= somewhere in the doc let me know as we need the user guides to be correct smiling smiley

It seems like in some former Piwik version, there was accidentally idSite instead of idsite as parameter.
Since this is corrected in Piwik itself, maybe the idSite-Error comes from CustomOptOut-Plugin?

Running plugin with hundrets / thousands of websites

Loading the CustomOptOut settings is not possible if you have hundrets or even thousands of websites in Piwik. Similar to the new website administration in Piwik, the plugin settings should use a paginatable list (and search) for displaying the overview (or single items).

Popup position will be ignored after changing Piwik Settings on Website (Opt-In/Out)

hi,
using latest plugin version 0.40. i'm working with popup as written above.
when first try to show tracking settings poup, it will be shown in foreground. if you change the hook for do not track your visit, then the popup will be moved to the background.
this isn't very comfortable and with older versions the issue doesn't exist.
br,
newbie2004

OptOut not working in Google Chrome

Hi there,

piwik_ignore Cookie is not set in Chrome. No activity. IE and Firefox are fine.

Environment;
Apache 2.2
Piwik 2.0.3
CustomOptOut (v0.1.4)
Chrome Version 33.0.1750.154 m
You have an idea what's wrong ?

Best
Daniel

broken piwik v2.12.0

Piwik Output after update to 2.12.0

Fatal error: Call to undefined method Piwik\Menu\MenuTop::addEntry() in /xxx/piwik/plugins/ExampleUI/ExampleUI.php on line 48
A fatal error occurred

The following error just broke Piwik (v2.12.0):

Call to undefined method Piwik\Menu\MenuTop::addEntry()
in
/xxx/piwik/plugins/ExampleUI/ExampleUI.php line 48

i this an piwik or customoptout Problem?

Tracking setting for different website won't be considered

hi,
i'm using self hosted version of latest piwik 2.1.5 with your latest plugin 0.40.
i have different websites with different ids.
for all sites tracking with piwik is allowed.
if you are visiting one website and change piwik setting to do-not-track and leave site then visiting another of your own website and check piwik settings here ... it is also set to do-not-track - independent of other idsite parameter.
same procedure from the other side.
br,
newbie2004

Possibility to change shown texts

Would be great if one could not only change the appearance (CSS) but also the 2 texts shown (marked or not) directly within this plugin.

With this function one could easily adopt this function when using piwik for sites with

  • different languages
  • different target groups (word choice and depth of given details for this function...)
  • different types of designation (e.g. in German there is a "Sie" and "Du" for "You" depending on whom you're talking to..)

custom css could not be saved

just trying to configure this great looking extension I found a problem:

  • putting CSS-code to the the field "Custom CSS" and
  • pressing the "Save" button
  • leaving the site and
  • coming back
    => the field is empty /the CCS code is disappeared

tested with Piwik 2.1.1B4 and CustomOptOut v0.1.4

2.16.5 compatibility

The plugin has been deactivated in my piwik for compatibility reasons with 2.16.5 (error message Das Plugin CustomOptOut ist nicht kompatibel mit Piwik 2.16.5). Any plans to add 2.16.5 compatibility?

Thanks!

Edit text strings or german translations for plugin

hi,
i had tried to modify the german translations for your plugin in different .json files (add to /lang/de.json, add to /plugin/CoreAdminHome/lang/ & /plugin/CustomOptOut/lang/), but don't get a result.
i'm using piwik in the newest version 2.9.1.
hope you can help!?
br,
newbie-2004

Fix setup

DB Update does not seem to work properly

Need to load a Google font

Hi Jens,
this plugin is really great, saved my day after much sweat and inadequate progress. It seems to work fine, but I use a Google font on one of my sites, so for the text to be in the same font as the rest of the website, I need to load it in the iframe too. I tried to sneak it in as the external css file, which of course does'nt work, just ended up with:

<link href="<link type="text/css" rel="stylesheet" href="http://fonts.googleapis.com/css?family=Roboto:400,400italic,700,700italic"&gt;?cb=bace8b099b9c268dbacd9fecc7531b8a" type="text/css" rel="stylesheet">

as was pretty much to be expected. So my feature request is, to provide a second box underneath the css file box, which is pasted straight into the head area without being wrapped in anything - this would give maximum flexibility.

Again, many thanks!

Please extend the plugin for custom js

Hi,

we use a responsive Layout and different Languages. Piwiks predefinition says that the iframe ist 200px high and has a 600px width. We need it more dynamic.

For other iframes we use easyXDM. There the iframe content can propagate its height to the parent. But currently I see no way to add the necessary js to the iframe.

Could you extend the PiwikCustomOptOut for custom js?

br,
Matthias Hermsdorf

Installing plugin overwrites plugins/.htaccess

Don't know if this is an issue with the plugin, or with Piwik plugin installation, but it happened three times in the three Piwiks that I added the plugin to:

BEFORE:
<Files ~ ".(php|php4|php5|inc|tpl|in)$">
<IfModule mod_access.c>
Deny from all
</IfModule>
<IfModule !mod_access_compat>
<IfModule mod_authz_host.c>
Deny from all
</IfModule>
</IfModule>
<IfModule mod_access_compat>
Deny from all
</IfModule>
</Files>
<Files ~ ".(test.php|gif|ico|jpg|png|svg|js|css|swf)$">
<IfModule mod_access.c>
Allow from all
</IfModule>
<IfModule !mod_access_compat>
<IfModule mod_authz_host.c>
Allow from all
</IfModule>
</IfModule>
<IfModule mod_access_compat>
Allow from all
</IfModule>
Satisfy any
</Files>

AFTER:
<Files "*">
<IfModule mod_access.c>
Deny from all
</IfModule>
<IfModule !mod_access_compat>
<IfModule mod_authz_host.c>
Deny from all
</IfModule>
</IfModule>
<IfModule mod_access_compat>
Deny from all
</IfModule>
</Files>

The result is, that Piwik can't access all its files and looks broken.
I'm surprised that I did'nt find anything here or via Google on this, since it happened to me on three different servers... (Ubuntu 12.04, Strato, All-Inkl)

Again thanks for a great plugin!

README incomplete

The file provides a changelog but not examples how to insert CSS. It will be nice to improve it.

CustomOptOut does not work in IE

Similar to this Piwik Core issue:
matomo-org/matomo#3135

If I use the original embedding method by Piwik (2.14) OptingOut works fine in IE:
index.php?module=CoreAdminHome&action=optOut&language=de will work, even if Piwik is installed on different domain.
If I use CustomOptOut, the checkbox will always be re-checked because the cookie is not set.
index.php?module=CustomOptOut&action=optOut&idSite=1&language=de

Any idea how to fix this for the plugin too? Maybe in the same way it got fixed in the core?

Empty X-Frame-Options header is sent

Hello,

I'm using your plugin with PIWIK. When I load the iframe into a site I'll get "Invalid 'X-Frame-Options' header encountered when loading 'https://piwik.holgerkral.de/index.php?module=CoreAdminHome&action=optOut&idsite=2&language=de': '' is not a recognized directive. The header will be ignored."

This URL is shown in PIWIK backend: https://piwik.holgerkral.de/index.php?module=CoreAdminHome&action=optOut&idsite=2&language=de and it sents an empty X-Frame-Options header (> curl -I ....)

In your screenshot the URL is https://piwik.holgerkral.de/index.php?module=CustomOptOut&action=optOut&idsite=2&language=de (CustomOptOut instead of CoreAdminHome as module). Testet with curl it doesn't sent a X-Frame-Options header.
But when I check this second URL in browser it is redirected to the first URL and so sending the empty header.

Best regards
Holger Kral

Font-display in mobile Safari / iOS

There seems to be an issue with the display of webfonts in mobile Safari and Chrome (iOS 10.1.1) – I simply cannot get the font to display correctly although it works fine in the desktop-versions of Safari, FF, Chrome etc.

Any idea as to why this might happen? Can the plugin do anything differently or is this simply related to a security setting (preventing XSS or the like)?

--> https://thomas-knaus.de/impressum/

Thanks + regards!
Henning

Setting css for generic opt in/out is useful

The plugin only shows css-input-fields for iframes with a site-id. But for the generic IFrame is no way to set the css.

/index.php?module=CoreAdminHome&action=optOut&language=de

There should be that possibility too. It also could work as a default for all unmodified site-ids.

PHP 7.2 support?

Hi there,

does PiwikCustomOptOut fully support PHP 7.2 and Matomo 3.8.x? Any known issues? Thank you for your excellent plugin.

possibility to disable "strong" for text beside checkbox

just a tiny thing: would be great if one could have the easy possibility to remove the different look of the short text beside the check box. (resulting from "strong")
This could be done e.g. via a new checkbox within piwik admin backend.
There are two reasons for that:

  1. looks much cleaner
  2. not every Piwik admin who wants to give the visitors the easy possibility "not to be tracked" wants to highlight this feature that much / more than necessary...

an other way to achieve this and even more would be the possibility to have an extra custom css for this part of the text too...

CustomOptOut for all sites

Hi! Is it possible to adapt style for all sites (iframe without siteid)?
If I use the module "CoreAdminHome" optout works for all included sites, but with
CustomOptOut only for one site (&action=optOut&idSite=1). I would like to have both: nice style but the functioning for all sites!?
Best regards!

Check DNT

If a DNT header was sent by the browser, the optout page should just tell the user he/she is not being tracked because of the way his/her browser's configured.

See:
matomo-org/matomo#7352

PiwikCustomOptOut only works when logged-in to Piwik

If I am logged out of Piwik I get the error message “You are not allowed to read the value of the setting "defaultCssStyles" in plugin "CustomOptOut"” shown in the Piwik-Iframe on the web page where I'd like to offer the Piwik Opt-out. Once I am logged into Piwik, the styling works as intended together with the proper message from Piwik.

I am using the latest version of Piwik (2.16.0) and your plugin (0.4.1)

escaped path to external css file

Hi,
i installed the plugin and entered the custom css, which works fine.

But i need to do some more tweaks why i tried to enter a path in "external css file", unfortunately the text in the html is escaped like:
http://www.domain.de/wpcontent/themes/
and so the css can not be found.
I also just upgraded to piwik 2.11.1, maybe the escaping happens somewhere there? Can you give me a hint where to look?

ZIP-File can not be extracted under Win7 64Bit

Hi,
there is a "." (dot) in the path of the directories inside the zip-file, which makes it impossible for WinZip under Windows7 to extract the files. 7zip does the job.
Please correct.

Cheers,
Nicolai

No individual PiwikCustomOptOut settings for the two websites of my Piwik installation.

The screenshot provided here on Github of PiwikCustomOptOut shows two individual configuration possibilities for PiwikCustomOptOut. I have two websites I am currently tracking with Piwik but the PiwikCustomOptOut plugin only shows one(!) configuration. This one is used for both websites. How do I enable site individual settings for PiwikCustomOptOut?

Works neither with Custom CSS nor with extrenal CSS file

No matter what I enter under Custom CSS or if I place the CSS instructions in an external CSS file and use the link: The iFrame code under the input fields does not change and only shows the "normal" values. What am I doing wrong?
screenshot 2018-12-08 at 12 05 12

Translations

Piwik recently started to give plugin developers the possibility to use the Piwik translation project to get translations for their plugins.
Are you interested in using it?

Custom opt-out not triggered when called via https

For security reasons some browsers don't load "http"-content within a "https"- page. So I need to call the opt-out content via https:// in the iframe.

If I do so, the custom-opt-Out plugin does not seem to trigger, the custom css is not used. Using http:// (and convincing the browser to load the unsecure content anyway) works quite normal.

Any idea why that is?

Wrong output text

If I "5) Use the iframe code provided below the input fields to add the Piwiki Opt-Out to your website."
the output is:
"CustomOptOut_YouMayOptOut
CustomOptOut_YouMayOptOutBis

CustomOptOut_YouAreOptedIn CustomOptOut_ClickHereToOptOut"
even if I test the output in Piwik.

Piwik 2.11.0 and Custom Opt-Out 0.2.0

Two questions

  1. is it normal my PiwikCustomOptOut only displays a CSS area (no JS)?
  2. is there any way to change the HTML before it is styled? At the moment, the only thing I can really set is the font-family

Reponsive height

For responsive websites or some other special cases it would be useful to let the iFrame grow responsively in height to either avoid scroll bars or a huge vertical gap at the bottom. Technically this could be implemented with window.postMessage.

Would this make sense or is it a too specific use case?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.