zeppelinos / kernel Goto Github PK
View Code? Open in Web Editor NEW:warning: Deprecated in favour of OpenZeppelin/openzeppelin-sdk
License: MIT License
:warning: Deprecated in favour of OpenZeppelin/openzeppelin-sdk
License: MIT License
The current ZepCore
implementation allows any KernelInstance
to be registered as long as the sender had set the due ZepToken allowance and there isn't a name/version clash in the registry.
Considering that:
KernelInstance
whose parent is not in the registry.I think we should include a validateInstance()
function (or modifier) to ZepCore's register()
to perform all the necessary checks before registering a KernelInstance
.
To start, I'd enforce that an instance has to be frozen and its parent registered, matching not only its name/version hash but its address too.
Thoughts?
See for example:
Line 130 in 42d6406
Check all uses of transfer
and transferFrom
(consider using SafeERC20
)
The developer
of a Release
is now set at creation time as msg.sender
. As is the case with owner
, consider providing the option of modifying the developer of a release later on.
Currently the tuple for identifying a contract is distributionName, version, contractName. Review the need for distribution name in the model for representing a version tree.
Let's add more integration tests to cover:
Right now, the _newVersionCost
variable specifying the cost of deploying a new kernel version, and _developerFraction
, which specifies the fraction of each vouch that is forwarded to the version developer, are fixed by ZepCore
's constructor. The only way to modify them is to go through a full kernel upgrade.
We should evaluate the possibility of introducing a mechanism to change these without resorting to an upgrade (maybe a simple setter would do?).
See:
Line 76 in 6327d83
Changes from commit e251e15 was lost during a merge were lost. Re-merge them.
The tools under deploy are not only useful for this repo but for zos dapp development in general.
We have name
in function getInstance(string name, string version)
and distribution
in function getImplementation(string distribution, string version, string contractName)
, which calls getInstance(distribution, version)
inside..
Should be fixed when solving OpenZeppelin/openzeppelin-labs#68.
Solved in #13.
Spawned from code TODO at
Line 133 in 6327d83
Currently the Kernel owns an instance of a Vouching contract where it keeps track of vouching numbers. This separation adds unnecessary complexity. Let's consider making Kernel is Vouching
and not making Vouching
an Ownable
so as to keep all state in the same "physical" contract.
Replace deploy and createapp scripts with dependencies from https://github.com/zeppelinos/cli
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.