zeppelinos / kernel Goto Github PK

The current ZepCore implementation allows any KernelInstance to be registered as long as the sender had set the due ZepToken allowance and there isn't a name/version clash in the registry.

Considering that:

1. Although our current staking model encourages forking from a high-staked distribution version to attract its "audience", the base kernel needs to be frozen to be a fork's parent and that's up to the base kernel developer. This way, the developer can "deny" other developers forking from it.
2. Stakers today can stake for an unfrozen (mutable) distribution version. This allows the developer to add new implementations after staking.
3. I can register a KernelInstance whose parent is not in the registry.

I think we should include a validateInstance() function (or modifier) to ZepCore's register() to perform all the necessary checks before registering a KernelInstance.

To start, I'd enforce that an instance has to be frozen and its parent registered, matching not only its name/version hash but its address too.

Thoughts?

See for example:

Check all uses of transfer and transferFrom (consider using SafeERC20)

The developer of a Release is now set at creation time as msg.sender. As is the case with owner, consider providing the option of modifying the developer of a release later on.

Currently the tuple for identifying a contract is distributionName, version, contractName. Review the need for distribution name in the model for representing a version tree.

Let's add more integration tests to cover:

• staking
• registering and fetching kernel instances

Right now, the _newVersionCost variable specifying the cost of deploying a new kernel version, and _developerFraction, which specifies the fraction of each vouch that is forwarded to the version developer, are fixed by ZepCore's constructor. The only way to modify them is to go through a full kernel upgrade.

We should evaluate the possibility of introducing a mechanism to change these without resorting to an upgrade (maybe a simple setter would do?).

See:

Changes from commit e251e15 was lost during a merge were lost. Re-merge them.

The tools under deploy are not only useful for this repo but for zos dapp development in general.

We have name in function getInstance(string name, string version) and distribution in function getImplementation(string distribution, string version, string contractName), which calls getInstance(distribution, version) inside..

Should be fixed when solving OpenZeppelin/openzeppelin-labs#68.

Solved in #13.

Spawned from code TODO at

Currently the Kernel owns an instance of a Vouching contract where it keeps track of vouching numbers. This separation adds unnecessary complexity. Let's consider making Kernel is Vouching and not making Vouching an Ownable so as to keep all state in the same "physical" contract.

Replace deploy and createapp scripts with dependencies from https://github.com/zeppelinos/cli