zero-to-mastery / js_fun_practice Goto Github PK

When running test using the "npm run test" command, all tests seems to be working fine but one. I think there is a problem with one of the solutions that were pushed to the zero-to-mastery repo, specifically in the file named "schmeb0704_solution.js" located in the Solutions folder.

The readme contains a potential parentheses mismatch in the addmTwo example, specifically in the second usage example:

addmTwo(m(1, m(Math.PI, 'pi'))) // {value:4.14159..., source:"(1+pi)"}

It seems there might be an extra closing parenthesis at the end of the source value. The correct representation should likely be:

addmTwo(m(1), m(Math.PI, 'pi')) // {value:4.14159..., source:"(1+pi)"}

This adjustment ensures that the parentheses in the source value are properly matched and represent the intended mathematical expression.

Please review and address this discrepancy in the readme.

Thank you!

It would be cool if there was a way to run tests.

Example:
I create a new JavaScript file with my solutions in Solutions/my-solutions.js.

I run npm run test.

The test runner will tell me if I have any errors.

Caveat: I don't want failing tests to be blocking for a PR. ZTM members should be able to add solution files to this repository regardless of failing tests.

package.json is showing various errors whilw launching the file, like directory or compiling issue

The generator functions (genFrom, genTo, etc) don't have the same return format in the tests and in the examples in the README.md.

In the tests, the format follows the iterator protocol (an object with a next method that returns a value and a done property) and in the examples it only returns a value.

Someone to please enlighten me more on how to use the project and contribute to it, thanks.

I found this open-source community while I was searching for open-source project to contribute.
I am looking forward to contributing to the projects.