zerobounce / zerobounce-java-api-v2 Goto Github PK

The nested class ZeroBounceResponse is marked protected, and this will cause access violations when running in newer JVMs. Instead, it must be public to be accessible to the clients using this API, and it should also be static since there's no need for the response object to track the API implementation.

• The timeout is set by default at 10 MILLISECONDS

• URI in validate method is set with validatewithip but this url seems deprecated

For testing purposes, it is useful to be able to mock out external services, and this is much easier in Java with an interface. Introducing an interface that the class implements will make testing client code easier.

There are a number of compilation issues regarding method signatures and unknown variables. Nome variable naming conventions are also non-standard.

The current code throws a checked URISyntaxException, but all of the URIs being constructed are under the control of the library itself. The library can guarantee that the values being passed (e.g., API keys) are syntactically valid and remove the need for the calling client to handle URISyntaxException itself.