A spigot plugin for Minecraft servers. Restricts certain block placements and removes illegals from player inventories.
Home Page: https://www.curseforge.com/minecraft/bukkit-plugins/antiillegals
License: MIT License
![dependabot[bot] avatar](https://avatars.githubusercontent.com/in/29110?v=4 "dependabot[bot]")
1.20.*
If the target does not have the enchantment, it gains all levels of that enchantment, unless it already has an incompatible enchantment. Enchantments are incompatible if both are in one of the following groups:
Randomly select one enchmantment that remains on the item?
completely unrelated anti illegal checks should probably be in different methods. this is especially important with the oversized books check, because that is the only part of the itemstack checking method that requires the location parameter. making a method for illegal items separate from a method for books would allow reverting illegal items at other places without needing to check for books at the same time.
in the pickup item event, an unnecessary check for whether the entity is a player is performed. this makes the code a little bit verbose, but more importantly it allows entities with possible equipment to hold illegal items.
the check for when offhand items are swapped is flawed, as it checks if the item to revert is null AND illegal (which is never the case, air is not illegal). changing the first == to != should fix this, same goes for the check below it
any time checkItemStack is used in Events, it checks if the ItemState returned by the method is ItemState.illegal. this creates a bypass for things like overstacked items when they are picked up from the ground, because in order to fully revert the item, the event needs to be cancelled. because reverting overstacked items only results in ItemState.wasFixed, this is not handled correctly (as well as in other places)
message: "[BlockPlaceEvent] Stopped xyz from placing CraftBlock"
By default this plugin kicks all books out of a shulker if there are > 5 books, no matter how big or small they are. It would be nice if we could opt-in to that behavior, or if there was a byte check for book size to prevent book bans.
Limiting shulkers to just 5 books is difficult for book collectors and I am still testing but it seems that m moving shulkers in e-chests can result in deleted books.
there is duplicated code in AntiIllegals.java#L159 and ShulkeredBooksCleaner.java#L16
Could not pass event InventoryOpenEvent to AntiIllegals v1.0.41
org.bukkit.event.EventException: null
at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:72) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:513) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at org.bukkit.craftbukkit.v1_12_R1.event.CraftEventFactory.callInventoryOpenEvent(CraftEventFactory.java:825) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at net.minecraft.server.v1_12_R1.EntityPlayer.openContainer(EntityPlayer.java:858) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at net.minecraft.server.v1_12_R1.BlockChest.interact(BlockChest.java:308) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at net.minecraft.server.v1_12_R1.PlayerInteractManager.a(PlayerInteractManager.java:550) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at net.minecraft.server.v1_12_R1.PlayerConnection.a(PlayerConnection.java:1025) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at net.minecraft.server.v1_12_R1.PacketPlayInUseItem.a(PacketPlayInUseItem.java:37) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at net.minecraft.server.v1_12_R1.PacketPlayInUseItem.a(PacketPlayInUseItem.java:5) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at net.minecraft.server.v1_12_R1.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:14) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_352]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_352]
at net.minecraft.server.v1_12_R1.SystemUtils.a(SourceFile:46) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:851) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:427) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:775) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:666) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_352]
Caused by: java.lang.IllegalArgumentException: Specified enchantment cannot be applied to this itemstack
at org.bukkit.inventory.ItemStack.addEnchantment(ItemStack.java:444) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
at org.zeroBzeroT.antiillegals.AntiIllegals.checkItemStack(AntiIllegals.java:309) ~[?:?]
at org.zeroBzeroT.antiillegals.AntiIllegals.checkInventory(AntiIllegals.java:114) ~[?:?]
at org.zeroBzeroT.antiillegals.AntiIllegals.checkItemStack(AntiIllegals.java:322) ~[?:?]
at org.zeroBzeroT.antiillegals.AntiIllegals.checkInventory(AntiIllegals.java:114) ~[?:?]
at org.zeroBzeroT.antiillegals.AntiIllegals.checkInventory(AntiIllegals.java:94) ~[?:?]
at org.zeroBzeroT.antiillegals.Events.onInventoryOpen(Events.java:210) ~[?:?]
at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor3.execute(Unknown Source) ~[?:?]
at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:70) ~[patched_1.12.2.jar:git-Dionysus-"42ce9ca"]
... 19 more
in a lot of places it gets extremely confusing whether the variable you're working with can be null or not. adding annotations like these would remove a lot of mental workload trying to figure out if something can ever be null
there is a lot of copypasted, reused expressions that can easily be stored in local variables. not using them just makes every line impossible to grasp, some lines even go beyond the usual screen width
The code we had for unbreakables deleted some items like beds:
if (itemStack.getType().isItem() && !itemStack.getType().isEdible() && !itemStack.getType().isBlock()) {
if (itemStack.getDurability() > itemStack.getType().getMaxDurability() || itemStack.getDurability() < 0 || itemStack.getItemMeta().isUnbreakable()) {
itemStack.setDurability((short) 0);
itemStack.getItemMeta().setUnbreakable(false);
itemStack.setAmount(0);
}
}the caching is currently only done on the 1.12.2 branch and should be moved to the 1.20 branch as well.
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.