zerodha / kiteconnect-mocks Goto Github PK

In Accordance with the Kite Connect 3 / API documentation, The MF Holdings Holdings contain the user's portfolio of allotted mutual fund units. response shall contains the key last_price_date key in each item of the mf holdings data array. It is mentioned in the Response attributes as last_price_date (Type: String) - Date for which last NAV is available.

However, the mock response file mf_holdings.json contains the last_price_date key and value in the first element of the mf_holdings data array of five elements, rest four array elements have the key last_price_date missing.

Which shouldn't be the case, since it has not been marked as Type: null, String in the Response attributes which would have informed the end user that the key & value of last_price_date is optional and may and may not be there in each element of the mf_holdings array.

Seeking Clarity in regards of the last_price_date key to be optional or mandatory. Thank You.

While Retrieving an individual SIP, the server returns the sip details in the format mf_sip_info.json which contains the last_instalment details as the timestamp at which the last instalment was triggered.

And while Retrieving all SIPs the server returns the list of all active and paused SIPs in the format mf_sips.json which contains an array of all the individual sip details in the format mf_sip_info.json with the same last_instalment details as the timestamp at which the last instalment was triggered.

However, in both responses the last_instalment details type mismatches:

1. The mf_sip_info.json shows the last_instalment timestamp as 2021-06-10 08:37:11.273142 with microseconds in it, Hence the effective format is %Y-%m-%d %H:%M:%S%.f
2. The mf_sips.json shows the last_instalment timestamp as 2021-05-05 05:56:27 without the microseconds, Hence the effective format is %Y-%m-%d %H:%M:%S

Since mf_sip_info.json is a subset of mf_sips.json, both should have the same timestamp format to easily deserialize with reusable code. In addition, Kite Connect 3 / API documentation highlights the [Response attributes](Kite Connect 3 / API documentation) to be consistent in both responses.