zhangtaoeasy / as3-stomp Goto Github PK

Hi,

Thanks for the great stomp client. :)

We have found a little problem when sending UTF-8 messages to server.

Digging into code, We found a small bug at line:231 of Stomp.as, the
content-length of a unicode string should be the length in bytes.
It should be:

var bodyBytes:ByteArray = new ByteArray();
bodyBytes.writeUTFBytes(body);
transmission += "content-length:" + bodyBytes.length + NEWLINE;            

Or maybe there is a better way to calculate the length in bytes.

BR,
Yenwen Feng

Was trying to do a benchmark, and for some reason I randomly get this error 
thrown... 

Shouldn't I be able to catch this error (without modifying the class)? 
Basically, I think the throw new Error should be dispatchEvent(new 
StompErrorEvent.ERROR()) or something...

Here's the code 

var sh:SendHeaders = new SendHeaders();
            sh.addHeader("exchange","amq.topic");
            for (var i:int = 0; i < 3000; i++)
            {
                //sh.addHeader("routing_key","#");
                stmp.send("test", "ABC "+i,sh);
            }
            trace("End");

Each time I run it, I have an UNKNOWN STOMP FRAME thrown at one of the 
packets... Sometimes 910, sometimes 50, sometimes 1400...

What steps will reproduce the problem?
1. launch ActiveMQ and go to the admin console
2. launch the as3Stomp client
3. in the ActiveMQ admin console go to the send page and enter a message
that contains several hundred characters. Enter 1000 in the "Number of
messages to send" field, and in "Destination" field enter the queue name
that the client subscribed to (e.g., test).

What is the expected output? 

The client should receive all 1000 messages and dispatch a MessageEvent for
each one.

What do you see instead?

The client throws an error after receiving several messages.  The
FrameReader does not parse the messages correctly because the stream
contains multiple messages and the FrameReader only grabs the first one and
 then discards the bytes of the remaining messages.

What steps will reproduce the problem?
1. make the reconnect time larger (from default 5 to 30 times)
2. connect stomp
3. un-plug cable, wait for 3 to 4 seconds, reconnect


What is the expected output? What do you see instead?

expect: reconnect successfully.
actual: stomp recieved 'xxx-client-xxxxx already connected from /XXXX




What version of the product are you using? On what operating system?

- v0.41

Please provide any additional information below.

http://stomp.github.com/stomp-specification-1.1.html#Repeated_Header_Entries 
states that "only the first header entry SHOULD be used as the value of header 
entry". The implementation in repository version 17 instead always overwrites 
previous header values.

The change would be needed in Stomp.as in function processHeaders(), but it 
probably requires either a compatibility flag or be based on the STOMP version 
reported by the server, since it risks breaking working implementations... 
(mine wasn't working because of this).

public  var buffer:ByteArrayReader = new ByteArrayReader();
buffer.writeUTF("This is text in a buffer");
buffer.forwardBy(buffer.bytesAvailable);
var x:int = scanit(0x00);

What is the expected output? What do you see instead?
x should contain -1, contains 0, scan is looping through unitialised 
memory so results could be unpredictable

What version of the product are you using? On what operating system?
r8

Please provide any additional information below.

I've got a patch for this and for some other issues I'm working on. If 
it's any use let me know where and I can upload them.

Many thanks

Peter Mulreid

I'm using the latest svn revision of the as3 stomp code.

The SubscribeHeaders object does not contain an 'exchange' header, or a
'routing_key' header, both of which are required in order to subscribe to
fanout or topic exchanges in rabbitmq.  Without the ability to specify
these headers, it is not possible to broadcast messages.

I was able to fix this functionality very quickly, by adding the required
headers to the SubscribeHeaders.as file, and recompiling the code.  After
making the necessary adjustments to the Sender and Receiver clients I was
able to then successfully send messages via the default amq.topic exchange
in rabbitmq.

Although there is a bit of AMQP bleeding through here, this is a very
trivial addition, and would provide some nice added functionality to future
version of this client library.

I have attached my modified versions of SubscribeHeaders.as where I have
added the additional headers.

What steps will reproduce the problem?
1. Create Topic consumer by AS3 Stomp Client.
2. ActiveMQ doesn't send any message in at least 10 minutes.
3. AS3 Stomp Client can not receive any message any more.
4. Check ActiveMQ console and found the number of Topic's consumer decreased 1 

What is the expected output? What do you see instead?
AS3 Stomp client should keep alive if don't call its close or other similar
close function. 

What version of the product are you using? On what operating system?
V0.6 and Windows XP SP2

What steps will reproduce the problem?
1. Use of the Flash CS3 IDE instead of Flex

Probable Solution:
Not using the mx.utils.ObjectUtil class, since it isn't available in flash.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.

What steps will reproduce the problem?
1. I wrote a java client that communicate Chat sample with openwire protocol.
2. I also rewrote StompChat sample to use latest version of as3-stomp_05,
because  of unicode problem.
3. Java client sends TextMessage and StompChat receives it well.
4. Openwire client receives BytesMessage type from as3-stomp clients.

What is the expected output? What do you see instead?
Openwire clients prefer TextMessage type when String type messages.

What version of the product are you using? On what operating system?

Version: as3-stomp_05_source.zip
On Windws-XP and ActiveMQ.

Please provide any additional information below.

ActiveMQ converts message to BytesMessage for openwire client, if
'content-length' header exists.
Attached changes works well for me.

Best regards,

Maeda.Masahiro at fujixerox.co.jp

Currently, the AS3 Stomp client always sends a content-length header with
every frame.  ActiveMQ keys off the the inclusion of this header to
determine if the message should be a TextMessage or a BytesMessage.  See
this page for more details: http://activemq.apache.org/stomp.html


It appears that some clients cannot receive BytesMessages. When the
content-length header is removed they successfully receive the messages
from the AS3 client, when it is included they do not.

What steps will reproduce the problem?

Setup a flash client to subscribe to a queue using the following code:

var stomp:StompClient = new StompClient();
stomp.connect("localhost", 61613);
var subscribeHeaders: SubscribeHeaders = new SubscribeHeaders();
subscribeHeaders.amqExclusive = "false";
stomp.subscribe(queue, subscribeHeaders); 

What is the expected output? What do you see instead?
Expected output is that two flash clients running the same swf file are able to 
consume a message X on the queue.

Instead only one of the clients get to consume the message.

What version of the product are you using? On what operating system?
The OS is windows 7 with flex builder 4.  We use Apache ActiveMQ v5.x

Please provide any additional information below.

It looks like as3Cryto is used in as3amqp for ssl/tsl support. Could it be
used in this project too? I would like to use as3-stomp to talk to ActiveMQ
in a project but at some point I know I'll need to start using ssl.

What steps will reproduce the problem?
1. unknown

What is the expected output? What do you see instead?
After some time of correct function: Exception is thrown
Runtime exception 2002: Operation attempted on invalid socket.
socket is not closed, so no reconnect is triggered.

What version of the product are you using? On what operating system?
version 0.3

Please provide any additional information below.

What steps will reproduce the problem?
1. Setup ActiveMQ.
2. Serve appropriate cross-domain file
3. Stop ActiveMQ, but leave server up with cross-domain file.
4. Attempt to connect.  You'll get a SecurityException about 20 seconds
after you get an IOErrorEvent (and screws up the reconnecting).

What is the expected output? What do you see instead?
No SecurityException should be reported later, only the initial IO exception.

What version of the product are you using? On what operating system?


Please provide any additional information below.

Attached is a patch file that fixes this issue, and exposes
securityexception events from Stomp.as.

Also added:
- ReconnectFailedEvent
   - thrown when a reconnection attempt has failed (rather than throw an
exception in the event thread where it cannot be caught).
- Changed the reconnect strategy to try once every minute, indefinitely.
(ReconnectFailedEvents are thrown on reconnect failures, allowing the app
to track progress if it wants to).

- Close socket events now work with Flex 4.

I can't seem to email you through Google Code (or rather, I should say, I
can't figure out how to do that).  If you have questions for me, I'd love
to work towards getting this patch integrated, and I'll check the comments
here for responses.

Thanks much for a great library!