zivtech / bear_skin Goto Github PK

Hi there,

I was just wondering if there is an example of the generated patternlab files from Bear skin? Thank you so much for the work and repo. Project looks super cool!

Many thanks,

Ran into this issue because my Drupal 8 install couldn't parse the yaml file.

There's a space after version: in global-styles that is not a normal space character.

You can see in https://github.com/zivtech/bear_skin/blob/8.x-2.x/bear_skin.libraries.yml that the syntax highlighting is borked on that line. The property appears blue when it should be green.

Hope this helps.

This will be quick. We need to add list-style: none to the following selector:

See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details.

Update the preprocessors so pagination has more specific CSS classes.

Hi, I think I found a bug:
In the libraries file (docroot/themes/bear_skin/bear_skin.libraries.yml) there is a css file for the fonts included, but its filename is "web-fonts.css" and I think this should be "fonts.css" to grab the google fonts generated by gulp using fonts.list file, or at least that seems to be the current filename.

bear_skin.libraries.yml

global-styles:
  version: 1.x
  css:
    theme:
      css/web-fonts.css: <-- here
        minified: true
      css/bear_skin.css:
        minified: false
        ...

Let me know if I'm correct,
Thanks!
m

I'm installing the bear skin theme and when running gulp I get an error saying "Task 'serve' is not in your gulpfile".

It looks like the gulp watch task calls 'serve' but 'serve' isn't being defined in the gulpfile.

`(function () {
'use strict';

var gulp = require('gulp');
var yaml = require('js-yaml');
var fs = require('fs');
var assign = require('lodash.assign');
var backstopConfig = require('./backstop.json');
var argv = require('yargs').argv;
var runSequence = require('run-sequence').use(gulp);

// read default config settings
var config = yaml.safeLoad(fs.readFileSync('default.gulpfile.yml', 'utf8'), {json: true});
try {
// override default config settings
var customConfig = yaml.safeLoad(fs.readFileSync('gulpfile.yml', 'utf8'), {json: true});
config = assign(config, customConfig);
} catch (e) {
console.log('No custom config found! Proceeding with default config only.');
}

// should we build sourcemaps? "gulp build --sourcemaps"
var buildSourceMaps = !!argv.sourcemaps;
config.buildSourceMaps = buildSourceMaps;

var gulpRequireTasks = require('gulp-require-tasks');
gulpRequireTasks({
path: process.cwd() + '/gulp-tasks',
arguments: [config]
});

var patternLabTasks = require('./gulp-tasks/patternLab.js');
patternLabTasks(gulp, config);

var backstopTasks = require('./gulp-tasks/backstop.js');
backstopTasks(gulp, config);

var renameTasks = require('./gulp-tasks/rename/rename.js');
renameTasks(gulp, config);

gulp.task('watch', ['serve', 'styles:watch', 'scripts:watch', 'pl:watch']);
gulp.task('default', ['watch']);
gulp.task('build', ['styles:build', 'pl:build', 'favicons:build', 'images:build', 'fonts:download']);
gulp.task('favicons:build', ['favicons:generate', 'favicons:inject']);
gulp.task('audit', ['audit:specificity', 'audit:pa11y', 'audit:analyze']);

}());`

It should also be noted that the bear skin gulpfile doesn't run with gulp 4.0.0+. It throws an assertion error:

`assert.js:42
throw new errors.AssertionError({
^

AssertionError [ERR_ASSERTION]: Task function must be specified
at Gulp.set [as _setTask] (/data/sites/drupal8_starter_kit/drupal/docroot/themes/contrib/bear_skin/node_modules/undertaker/lib/set-task.js:10:3)
at Gulp.task (/data/sites/drupal8_starter_kit/drupal/docroot/themes/contrib/bear_skin/node_modules/undertaker/lib/task.js:13:8)
at /data/sites/drupal8_starter_kit/drupal/docroot/themes/contrib/bear_skin/gulpfile.js:41:8
at Object. (/data/sites/drupal8_starter_kit/drupal/docroot/themes/contrib/bear_skin/gulpfile.js:47:2)
at Module._compile (module.js:653:30)
at Object.Module._extensions..js (module.js:664:10)
at Module.load (module.js:566:32)
at tryModuleLoad (module.js:506:12)
at Function.Module._load (module.js:498:3)
at Module.require (module.js:597:17)`

It also should be noted that I had to use node v. 7.10.1 in order to get it to install properly.

I'm trying to install the bear skin theme on a drupal 8 site but it looks like there's a problem with the @page included in the templates. Everything seemed to install fine but when we go to the site we get a message saying the "website encountered an unexpected error" and in the logs we get an error saying that "@pages/page/page.twig isn't defined".

Here's the log from the connection.

web_1 | [Thu Sep 13 19:20:17.950911 2018] [proxy_fcgi:error] [pid 92:tid 140171907971816] [client 172.24.0.2:35710] AH01071: Got error 'PHP message: Uncaught PHP Exception Twig_Error_Loader: "Template "@pages/page/page.twig" is not defined in "themes/custom/bear_skin/templates/05-pages/page.html.twig" at line 34." at /var/www/drupal/vendor/twig/twig/lib/Twig/Loader/Chain.php line 129\n' web_1 | 172.24.0.2 - - [13/Sep/2018:19:20:17 +0000] "GET / HTTP/1.1" 500 68 cli_1 | 172.24.0.3 - 13/Sep/2018:19:20:17 +0000 "GET /index.php" 500 cli_1 | 2018-09-13 19:20:17,978 DEBG 'php-fpm' stderr output: cli_1 | 172.24.0.3 - 13/Sep/2018:19:20:17 +0000 "GET /index.php" 500 cli_1 | cli_1 | [13-Sep-2018 19:29:20] WARNING: [pool www] child 41 said into stderr: "NOTICE: PHP message: Uncaught PHP Exception Twig_Error_Loader: "Template "@pages/page/page.twig" is not defined in "themes/custom/bear_skin/templates/05-pages/page.html.twig" at line 34." at /var/www/drupal/vendor/twig/twig/lib/Twig/Loader/Chain.php line 129" cli_1 | 2018-09-13 19:29:20,605 DEBG 'php-fpm' stderr output: cli_1 | [13-Sep-2018 19:29:20] WARNING: [pool www] child 41 said into stderr: "NOTICE: PHP message: Uncaught PHP Exception Twig_Error_Loader: "Template "@pages/page/page.twig" is not defined in "themes/custom/bear_skin/templates/05-pages/page.html.twig" at line 34." at /var/www/drupal/vendor/twig/twig/lib/Twig/Loader/Chain.php line 129" cli_1 | web_1 | [Thu Sep 13 19:29:20.615185 2018] [proxy_fcgi:error] [pid 9:tid 140171828247272] [client 172.24.0.2:36210] AH01071: Got error 'PHP message: Uncaught PHP Exception Twig_Error_Loader: "Template "@pages/page/page.twig" is not defined in "themes/custom/bear_skin/templates/05-pages/page.html.twig" at line 34." at /var/www/drupal/vendor/twig/twig/lib/Twig/Loader/Chain.php line 129\n' web_1 | 172.24.0.2 - - [13/Sep/2018:19:29:20 +0000] "GET / HTTP/1.1" 500 68 cli_1 | 2018-09-13 19:29:20,634 DEBG 'php-fpm' stderr output: cli_1 | 172.24.0.3 - 13/Sep/2018:19:29:20 +0000 "GET /index.php" 500 cli_1 | cli_1 | 172.24.0.3 - 13/Sep/2018:19:29:20 +0000 "GET /index.php" 500

We have a running site and use this as base theme to develop our custom theme.
I was able to enable and apply the them but accessing the pattern-lab link /themes/custom/bear_skin/pattern-lab/public/ gives be broken pages. I am getting 404's in all files. See inspected element error below:

styleguide.html?1505447967165:25 GET http://localhost:8080/components/styleguide/custom-styleguide-specific.css 
styleguide.html?1505447967165:29 GET http://localhost:8080/components/vendor/bower/raw/flexboxgrid/dist/flexboxgrid.css 
styleguide.html?1505447967165:30 GET http://localhost:8080/css/bear_skin.css 
styleguide.html?1505447967165:5595 GET http://localhost:8080/components/styleguide/js/domready.js 
styleguide.html?1505447967165:5596 GET http://localhost:8080/components/styleguide/js/drupal.js 
styleguide.html?1505447967165:5594 GET http://localhost:8080/components/styleguide/js/styleguide.js 
styleguide.html?1505447967165:5593 GET http://localhost:8080/components/vendor/bower/js/jquery.js 
styleguide.html?1505447967165:5603 GET http://localhost:8080/js/scripts.js 
styleguide.html?1505447967165:5597 GET http://localhost:8080/components/styleguide/js/jquery.once.js 
styleguide.html?1505447967165:5594 GET http://localhost:8080/components/styleguide/js/styleguide.js 
styleguide.html?1505447967165:5595 GET http://localhost:8080/components/styleguide/js/domready.js 
styleguide.html?1505447967165:5596 GET http://localhost:8080/components/styleguide/js/drupal.js 
styleguide.html?1505447967165:5597 GET http://localhost:8080/components/styleguide/js/jquery.once.js 
styleguide.html?1505447967165:5603 

Of course when, I modify the path, say, href="/css/bear_skin.css" to href="/themes/custom/bear_skin/css/bear_skin.css" that would fix the error. But I dont want to put changes in all .html files the theme has.