znichola / ft_transcendence Goto Github PK

add the possibility to delete a conversation for either participant:

delte on /conversations/{user1}/{user2}

Do the css and stuff so it looks good,

also think about the options, pause, resume, player controles etc..

This menue needs to be created with all the apropriate options:

a list of users
a list to add user to the channel
user actions, toggle status admin/memebr, kick, ban mute, mute for time period

This has been super annoying to try pinpoint where the-f it's comming from. But I've got a pretty nice lead here:

https://tanstack.com/query/v4/docs/react/guides/migrating-to-react-query-4#setlogger-is-removed

a ball has a x% chance to split into 2 (smaller?) balls every time it crosses the middle field. game reset only when all balls disappear (= when scored).
if normal won with 5 points, then special won with 10? 15? 20?

This interface should be re structured to fit all the information we want to fetch about a user

How to inform the frontend that tfa is enabled ?
As of now, logging in returns a JSON object with the user login42, and 2fa status (true or false). If it is true, then the user should be asked for his Authenticator code, then a POST request to /tfa/{username}/login should be sent, with a body containing the code as tfaCode (6 characters string, no space)

What to provide to the frontend after a successful login ?
I currently send back the login42 of the logged in user. Please let me know if this work for you, or if you want me to return more/different data

I just wanted to propose a workflow that seem easy enough to me for the implementation of the matchmaking and management of multiple games :

• All users joining the matchmaking connect to the websocket, and are added to a userlist
• The server will match the first user in the userlist with the user with the closest rank (we can use cron to do it on a regular interval)
  • A Room is created within the same websocket
  • Both users are added to the room user list as player 1 and player 2
  • Both users are removed from the matchmaking user list
  • People joining as spectator will be added to the room list as spectator and will not be able to play

At this point, we can specify which room we want to emit too and only the users inside it will receive the information

Please let me know if that would work for you, or if you have any suggestion !

before redirecting to the auth page on a page refresh we should check if there is a login cookie and use that instead, it would avoid this annoying relog screen on each page refresh

When i'm on the profile page and i reload, i'm taken back to the login page.

This is to sort of solve the issue of idempotent post, react will by default do compenent rendering twice to help find non pure functions.

I chose to hide the PRIVATE chatrooms, but we need to see them if we're member of the chatroom, right?

TODO:

• pause if disconnect
• pause if button pause pressed?
• wait then timer to start game when all player connected through websocket

The following error is logged after doing a tfa login, which completely stops nest

[Nest] 924  - 10/16/2023, 12:34:05 PM   ERROR [ExceptionsHandler] Cannot read properties of undefined (reading 'emit')
TypeError: Cannot read properties of undefined (reading 'emit')
    at Object.socketOnTimeout [as timeout] (node:_http_server:767:37)
    at TransformOperationExecutor.transform (/backend/nestjs/node_modules/src/TransformOperationExecutor.ts:207:39)   
    at TransformOperationExecutor.transform (/backend/nestjs/node_modules/src/TransformOperationExecutor.ts:327:31)   
    at TransformOperationExecutor.transform (/backend/nestjs/node_modules/src/TransformOperationExecutor.ts:327:31)   
    at TransformOperationExecutor.transform (/backend/nestjs/node_modules/src/TransformOperationExecutor.ts:327:31)   
    at ClassTransformer.instanceToPlain (/backend/nestjs/node_modules/src/ClassTransformer.ts:25:21)
    at Object.classToPlain (/backend/nestjs/node_modules/src/index.ts:23:27)
    at ClassSerializerInterceptor.transformToPlain (/backend/nestjs/node_modules/@nestjs/common/serializer/class-serializer.interceptor.js:56:37)   
    at ClassSerializerInterceptor.serialize (/backend/nestjs/node_modules/@nestjs/common/serializer/class-serializer.interceptor.js:49:20)

The error could be because the last part of the login has to be done using Swagger as of now, no issue with a login without 2fa at all.
Will have to check again after implementing the login 2fa code to make sure this does not occur at all (otherwise welcome to 0/100)

https://stackoverflow.com/questions/49967779/axios-handling-errors

basically the idea is to set our own callback function that handles, the http errors, we would just re throw the errors that are not 401 and for 401 an invalidation of the authprovider, this will automatically redirect to the login page.

cards should be brought in line with the style of the side menu and chat page

the Friends table is used for relationship and should be renamed accordingly

if image loading fails, or the user does not have an image set, give a default image.

Bearer Token Authentication (what we're using) should only be used over HTTPS.
Also, we're transmitting the password for the chatroom over the network so communication should be encrypted.

• Unify backend and frontend serving points (nginx)
• Swagger for backend documentation and testing :) jerome says its great

it always seems to return

{
  "message": "Cannot change role of owner",
  "error": "Forbidden",
  "statusCode": 403
}

export const putUserFriendRequest = async (
  current_user: string,
  login42: string,
) => {
  return authApi
    .put<HttpStatusCode>("/user/" + current_user + "/friends/" + login42)
    .then((res) => res.data);
  // .catch((error) => console.log(error.toJSON));
};

the docs for react Query have a section for making axios requests and they don't do the useless then thing

https://tanstack.com/query/v4/docs/react/guides/query-cancellation#using-axios-v0220

to test and if useless remove it fron the Api-axios.tsx file, also this file should have a small letter to start as it's not a react component.

make it so the currect user card does not have the interaction button and it should also probably be highlighted in some way.

Instead of calling getCurrentUser allover the place, use the authContext to get the current user, then figure out how to get it so the current user gets updated, when there is an error.

This error keeps printing in the console, should be found and squashed, can't submit with errors being printed

Additional information needs to be displayed: the win / losses and current elo

Action buttons need to be present for adding friend / message / dule, same as on the player card, this restyle might need to go handin hand with the restyling of the player card in global ranking.

When generating a QR code for the user to scan, the generated QR code is returned as text (this text can be saved to a file to create the working QR Code)
Do you have any ways to use it in React to display the image from its data ? I cannot use the same ReadStream as I did for the user avatar because the QRCode is not locally saved

Is this something we want to do? Would it make the project better / would bootup times be faster, is it cleaner etc..

The menu box we have for the chat should be made properly reusable and so used for the dm, chatroom, and ranking search.

This issue ties in with #8 because it's currently a pain to pass proprs to the delete function.

The name filtering only displays user whose name start with the searched string, instead of every name containing it (/user endpoint already have this filtering implemented)

Current cookie name is hardcoded as test, probably better to set a name in the .env file !