GithubHelp home page GithubHelp logo

zockeraxel / crazyadvancementsapi Goto Github PK

View Code? Open in Web Editor NEW
56.0 56.0 33.0 257 KB

CrazyAdvancementsAPI is a full-fledged NMS-based API for creating and managing Advancements on Spigot Servers

Home Page: https://docs.crazyadvancements.endercentral.eu

Java 100.00%

crazyadvancementsapi's People

Contributors

gliczdev avatar zockeraxel avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

crazyadvancementsapi's Issues

Hex-Colored Player Display Name support

The advancement completed message is getting player's display name and if you have your display name set to a hex-colored nick, it will not show correctly that color. It will show a vanilla color instead

Here you can see that the first advancement message is a vanilla message, it is getting the vanilla team prefix & vanilla team color.

Second message is CrazyAdvancementsApi advancement message, which is getting player's display name and not showing the correct hex colors
image

Request update for 1.17.1

Is there any chance for this API gets an update for 1.17.1? since I have to use the 2.0 version which has a bug that get fixed in 2.0.2+ about Save File problem, and 1.17.1 can't use 2.0.2 version.

Unable to save or load advancement data

When attempting to save/load advancement data it fails with the error:

[18:30:56 ERROR]: Could not pass event PlayerJoinEvent to Woolsacre v1.0-SNAPSHOT
java.lang.NullPointerException: Cannot invoke "eu.endercentral.crazy_advancements.CrazyAdvancementsAPI.getDataFolder()" because the return value of "eu.endercentral.crazy_advancements.CrazyAdvancementsAPI.getInstance()" is null
        at eu.endercentral.crazy_advancements.manager.AdvancementManager.getSavePath(AdvancementManager.java:711) ~[woolsacre.jar:?]
        at eu.endercentral.crazy_advancements.manager.AdvancementManager.getSaveFile(AdvancementManager.java:715) ~[woolsacre.jar:?]
        at eu.endercentral.crazy_advancements.manager.AdvancementManager.loadProgress(AdvancementManager.java:819) ~[woolsacre.jar:?]
        at eu.endercentral.crazy_advancements.manager.AdvancementManager.loadProgress(AdvancementManager.java:809) ~[woolsacre.jar:?]
        at net.prolieum.woolsacre.events.PlayerJoin.onPlayerJoin(PlayerJoin.kt:66) ~[woolsacre.jar:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor138.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:75) ~[purpur-api-1.19-R0.1-SNAPSHOT.jar:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:76) ~[purpur-api-1.19-R0.1-SNAPSHOT.jar:git-Purpur-1708]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[purpur-api-1.19-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:672) ~[purpur-api-1.19-R0.1-SNAPSHOT.jar:?]
        at net.minecraft.server.players.PlayerList.postChunkLoadJoin(PlayerList.java:365) ~[purpur-1.19.jar:git-Purpur-1708]
        at net.minecraft.server.players.PlayerList.lambda$placeNewPlayer$1(PlayerList.java:307) ~[purpur-1.19.jar:git-Purpur-1708]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.tick(ServerGamePacketListenerImpl.java:341) ~[?:?]
        at net.minecraft.network.Connection.tick(Connection.java:577) ~[?:?]
        at net.minecraft.server.network.ServerConnectionListener.tick(ServerConnectionListener.java:232) ~[?:?]
        at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1609) ~[purpur-1.19.jar:git-Purpur-1708]
        at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:485) ~[purpur-1.19.jar:git-Purpur-1708]
        at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1441) ~[purpur-1.19.jar:git-Purpur-1708]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1208) ~[purpur-1.19.jar:git-Purpur-1708]
        at net.minecraft.server.MinecraftServer.lambda$spin$1(MinecraftServer.java:307) ~[purpur-1.19.jar:git-Purpur-1708]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]

Server: git-Purpur-1708 (MC: 1.19)
CrazyAdvancementAPI: 2.1.10

Duplicate toast & other questions

I am creating my advancements like so in my onEnable method:

for(Stamp stamp : Stamp.values()) {
			AdvancementDisplay rootDisplay = new AdvancementDisplay(Material.ARMOR_STAND, "Stamp Earned!", stamp.getName(), AdvancementFrame.TASK, true, false, AdvancementVisibility.HIDDEN);
			rootDisplay.setBackgroundTexture("textures/block/concrete_yellow.png");
			Advancement root = new Advancement(null, new NameKey("minepenguin", "STAMP_" + stamp.name()), rootDisplay);
			advancementManager.addAdvancement(root);
}

And then I am trying to send a toast to the player like so:

MinePenguin.advancementManager.addPlayer(p);
MinePenguin.advancementManager.grantAdvancement(p, MinePenguin.advancementManager.getAdvancement(new NameKey("minepenguin", "STAMP_" + stamp.name())));
MinePenguin.advancementManager.removePlayer(p);

However, I seem to be getting two toasts for a reason that's beyond me:

Am I doing something wrong?

And, is there any way to change the text of 'Advancement Made!'? Is this something that could be done through the api or by a texture pack?

Thank you & stay safe.

Multiversion support

It seems that each version of CrazyAdvancementsAPI only supports one version. Would it be possible to get multiversion support?

If addPlayer() fails or doesn't happen, saved progress resets

If addPlayer() does not happen for whatever reason, the player's progress towards advancements is overwritten by any save that happens (in my case, saving on logout).

Save file before login:
{"pottercraft:read_letter":["criterion.0"]}

Save file after quit:
{"pottercraft:read_letter":[]}

I am not sure if this is intended behavior or not but it doesn't seem like a good thing since a bug in someone's plugin could result in clobbering advancement progress.

Request update for 1.20.2

[15:23:29 ERROR]: [ModernPluginLoadingStrategy] Could not load plugin 'CrazyAdvancementsAPI.jar' in folder 'plugins'
org.bukkit.plugin.InvalidPluginException: java.lang.NoSuchMethodError: 'void net.minecraft.advancements.Criterion.<init>(net.minecraft.advancements.CriterionInstance)'
        at io.papermc.paper.plugin.provider.type.spigot.SpigotPluginProvider.createInstance(SpigotPluginProvider.java:127) ~[paper-1.20.2.jar:git-Paper-207]
        at io.papermc.paper.plugin.provider.type.spigot.SpigotPluginProvider.createInstance(SpigotPluginProvider.java:35) ~[paper-1.20.2.jar:git-Paper-207]
        at io.papermc.paper.plugin.entrypoint.strategy.modern.ModernPluginLoadingStrategy.loadProviders(ModernPluginLoadingStrategy.java:116) ~[paper-1.20.2.jar:git-Paper-207]
        at io.papermc.paper.plugin.storage.SimpleProviderStorage.enter(SimpleProviderStorage.java:39) ~[paper-1.20.2.jar:git-Paper-207]
        at io.papermc.paper.plugin.entrypoint.LaunchEntryPointHandler.enter(LaunchEntryPointHandler.java:36) ~[paper-1.20.2.jar:git-Paper-207]
        at org.bukkit.craftbukkit.v1_20_R2.CraftServer.loadPlugins(CraftServer.java:512) ~[paper-1.20.2.jar:git-Paper-207]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:273) ~[paper-1.20.2.jar:git-Paper-207]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1086) ~[paper-1.20.2.jar:git-Paper-207]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:315) ~[paper-1.20.2.jar:git-Paper-207]
        at java.lang.Thread.run(Thread.java:1589) ~[?:?]
Caused by: java.lang.NoSuchMethodError: 'void net.minecraft.advancements.Criterion.<init>(net.minecraft.advancements.CriterionInstance)'
        at eu.endercentral.crazy_advancements.CrazyAdvancementsAPI.<clinit>(CrazyAdvancementsAPI.java:83) ~[CrazyAdvancementsAPI.jar:?]
        at java.lang.Class.forName0(Native Method) ~[?:?]
        at java.lang.Class.forName(Class.java:495) ~[?:?]
        at java.lang.Class.forName(Class.java:474) ~[?:?]
        at org.bukkit.plugin.java.PluginClassLoader.<init>(PluginClassLoader.java:76) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.provider.type.spigot.SpigotPluginProvider.createInstance(SpigotPluginProvider.java:123) ~[paper-1.20.2.jar:git-Paper-207]
        ... 9 more

Error with paper-126

Hi,
I have an error with paper and CrazyAdvancementsAPI, could you correct it?

java.util.NoSuchElementException: decoder
at io.netty.channel.DefaultChannelPipeline.getContextOrDie(DefaultChannelPipeline.java:1119) ~[patched_1.15.2.jar:git-Paper-143]
at io.netty.channel.DefaultChannelPipeline.addAfter(DefaultChannelPipeline.java:320) ~[patched_1.15.2.jar:git-Paper-143]
at io.netty.channel.DefaultChannelPipeline.addAfter(DefaultChannelPipeline.java:308) ~[patched_1.15.2.jar:git-Paper-143]
at com.comphenix.protocol.injector.netty.PipelineProxy.addAfter(PipelineProxy.java:54) ~[?:?]
at eu.endercentral.crazy_advancements.AdvancementPacketReceiver.listen(AdvancementPacketReceiver.java:60) ~[?:?]
at eu.endercentral.crazy_advancements.AdvancementPacketReceiver.initPlayer(AdvancementPacketReceiver.java:92) ~[?:?]
at eu.endercentral.crazy_advancements.CrazyAdvancements.onJoin(CrazyAdvancements.java:192) ~[?:?]
at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor20.execute(Unknown Source) ~[?:?]
at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.15.2.jar:git-Paper-143]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.15.2.jar:git-Paper-143]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.15.2.jar:git-Paper-143]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:559) ~[patched_1.15.2.jar:git-Paper-143]
at net.minecraft.server.v1_15_R1.PlayerList.a(PlayerList.java:192) ~[patched_1.15.2.jar:git-Paper-143]
at protocolsupport.zplatform.impl.spigot.network.handler.SpigotLoginListenerPlay.joinGame(SpigotLoginListenerPlay.java:137) ~[?:?]
at protocolsupport.protocol.packet.handler.AbstractLoginListenerPlay.joinWorld(AbstractLoginListenerPlay.java:145) ~[?:?]
at protocolsupport.protocol.packet.handler.AbstractLoginListenerPlay.lambda$finishLogin$1(AbstractLoginListenerPlay.java:88) ~[?:?]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_242]
at net.minecraft.server.v1_15_R1.MinecraftServer.b(MinecraftServer.java:1198) ~[patched_1.15.2.jar:git-Paper-143]
at net.minecraft.server.v1_15_R1.DedicatedServer.b(DedicatedServer.java:430) ~[patched_1.15.2.jar:git-Paper-143]
at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:1112) ~[patched_1.15.2.jar:git-Paper-143]
at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:934) ~[patched_1.15.2.jar:git-Paper-143]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]```

Licensing

What license is the code offered under?
Appreciate the time and effort you’ve put into this project!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.