zomzog / changelog-checker Goto Github PK

The following actions uses node12 which is deprecated and will be forced to run on node16: Zomzog/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Ref: https://github.com/pmem/pmdk/actions/runs/5924425697

Hi there,

I tried setting up this action with the following config:

name: Enforce Changelog Update
on:
  pull_request:
    types: [assigned, opened, synchronize, reopened, labeled, unlabeled]
    branches:
      - main
jobs:
  build:
    name: Check Actions
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v1
      - name: Changelog check
        uses: Zomzog/[email protected]
        with:
          fileName: CHANGELOG.md
          noChangelogLabel: no changelog
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Now when there's a PR against main, the action is running but always outputs the following error (and still passes the check even when no changelog change has been made):

Run Zomzog/[email protected]
(node:1485) UnhandledPromiseRejectionWarning: HttpError: Resource not accessible by integration
    at /home/runner/work/_actions/Zomzog/changelog-checker/v1.1.0/dist/index.js:7752:23
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
(node:1485) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:1485) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

The CHANGELOG.md file is present in the root of the project, so I'm not sure what else I could do to fix it?

See: https://github.com/Zomzog/changelog-checker/blob/master/README.adoc

Hi!

Node.js 12 actions are deprecated.
Could you update it to Node.js 16?

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Hi, thank you for making this awesome GitHub Action. This is exactly what I was looking for in my project ever since I forgot to edit the changelog in my last few PRs.

I wanted to request whether you can change the default filename to CHANGELOG.md since that is the default filename used by a huge number of coders and organizations worldwide, and it is also the default filename processed by GitHub, GitLab, Bitbucket, and other major repository providers. In addition, the standardized specification for the Changelog format at keepachangelog.com that has been adopted by a huge number of code repositories also says to use the default filename CHANGELOG.md. (On the website, you can scroll down to see the FAQ "What should the changelog file be named?" to see their statement)

checker throws error also when I overwrite default value.

see: https://github.com/Zomzog/changelog-checker/actions/runs/3862799334/jobs/6584588801

in dependanbot you can also

 .github/dependabot.yml:6: updates: │
─────────────────────────────────────┘
  6 ⋮  6 │      interval: 'weekly'
  7 ⋮  7 │      day: 'monday'
  8 ⋮  8 │      time: '09:00'
  9 ⋮    │      timezone: 'Europe/Warsaw'
    ⋮  9 │      timezone: 'Europe/Warsaw'
 10 ⋮ 10 │    target-branch: "dev"
    ⋮ 11 │    labels:
    ⋮ 12 │      - "skipChangelog"

so it would be nice feature to automate bumping libs on github and then add summary changelog before release

Works great on normal sized PRs, but for larger PRs it does not seem to detect the change in the Changelog

Force-push to the source branch for the given PR seems to work around the issue.

Before force-push: https://github.com/pmem/pmdk/actions/runs/5819012690
After force-push: https://github.com/pmem/pmdk/actions/runs/5819349562

No changes to the PR's labels before and after.

We're getting a warning when running the changelog checker action as described in the readme: https://github.com/fission-suite/webnative/actions/runs/1037261430

Unexpected input(s) 'checksNotification', valid inputs are ['fileName', 'noChangelogLabel', 'checkNotification']

But from looking at the code and readme, it looks like Simple and Detailed should be the valid inputs, right?