Update name in Ledger Live to "Stacks (STX)" about ledger-stacks

[jleni]

As explained by Gaetan:

for example, for the Ethereum (ETH) entry in Manager,
the app name is Ethereum
we lookup in our “@ledgerhq/cryptoassets” library a cryptocurrency that correspond to managerAppName = "Ethereum" , we find ethereum, we take the .ticker https://github.com/LedgerHQ/ledgerjs/blob/master/packages/cryptoassets/src/currencies.js#L974
{{appName}} ({{ticker}}) formatted if a currency was found, otherwise fallback to just {{appName}}
We try to put all the currencies in this library as soon as there is an app for it (regardless of if Ledger Live support it)
but the ticker must not be part of the app. (edited)

To fix this issue we need to send a PR to https://github.com/LedgerHQ/ledgerjs

[jleni]

The change was accepted by Ledger 2 weeks ago, however, it depends on their release schedule when it will appear in a released version. I think the best option is to ping them in their Slack.

[jleni]

we need to add something similar this:

https://github.com/LedgerHQ/ledgerjs/blob/01f9281d5df9dec2131ef5d9b5f73a6ee2b72294/packages/cryptoassets/src/currencies.js#L1008-L1026

for stacks

[jleni]

The managerAppName comes from here:

https://github.com/Zondax/ledger-blockstack/blob/91a5a75181316182d4ba79fc7a2ad9dc410908d1/app/Makefile#L58

[emmanuelm41]

PR on LedgerHQ

LedgerHQ/ledgerjs#562

[markmhx]

Thanks @emmanuelm41!

[emmanuelm41]

The PR was approved. We should have this issue fixed. Can you confirm that @markmhx?

[markmhx]

I'm still seeing just "Stacks" in search results personally:

[markmhx]

@emmanuelm41 Any updates here? I'm still seeing the app listed without the ticker.

[markmhx]

I see the change now having updated my version of Ledger Live: