GithubHelp home page GithubHelp logo

zotroneneis / magical_universe Goto Github PK

View Code? Open in Web Editor NEW
834.0 52.0 60.0 3.16 MB

Awesome Python features explained using the world of magic

Home Page: http://alpopkes.com/year-archive/

Python 100.00%
python python-3 coding coding-challenge 100daysofcode

magical_universe's Issues

Undefined names

flake8 testing of https://github.com/zotroneneis/harry_potter_universe on Python 3.7.0

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./code_per_day/day_16_to_18.py:50:16: F821 undefined name 'now'
        return now - self.birthyear
               ^
./code_per_day/day_16_to_18.py:106:16: F821 undefined name 'now'
        return now - self.birthyear
               ^
./code_per_day/day_8.py:47:70: F821 undefined name 'tr'
    def __init__(self, name: str, birthyear: int, sex: str, subject: tr, house: str = None):
                                                                     ^
3     F821 undefined name 'now'
3

Day 2: Grades Dictionary contains duplicate key

Hey!

In the blog post of Day 2 you give examples for static methods, however the dictionary used in the passed method contains the duplicate key "P":

grades = {
               'O': True,
                'Ordinary': True,
                'P': True,
                'Passed': True,
                'A': True,
                'Acceptable': True,
                'P': False,
                'Poor': False,
                'H': False,
                'Horrible': False,
                }

Don't think it's utterly important as the method does not show up in the code for the day. In addition to that the second occurence should overwrite the first so it still returns a value when calling the method.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.