ztombol / bats-support Goto Github PK

The code uses e.g cat which may be mocked/stubbed by the user and point to something else.

I'd suggest to get the real locations on startup (e.g. command -v cat or which cat) and save them for later use.

Alternative:

During startup (global scope): _BATSLIB_PATH="$PATH"
Call site: PATH="$_BATSLIB_PATH" \cat -

This resets the path and avoids macro/alias expansion

not sure if there is anything valuable in here, but worth checking out:

https://github.com/niieani/bash-oo-framework

script/install-bats.sh references https://github.com/sstephenson/bats instead of https://github.com/bats-core/bats-core

This should be updated or removed

A point of confusion that I had at first, and potentially for others, is the bats-core name. Even as someone who has been following this stdlib extraction for a while, the bats-core name suggests it is the "core" component of bats. ie, the runner.

rspec is similarly broken down into component gems:

• rspec-core being the runner
• rspec-expectations being the assertions
• rspec-mocks for stubs/doubles/mocks
• rspec-support being the shared lib used by all rspec-* gems

rspec-support plays the same role in the rspec ecosystem as this bats-core does, but IMO, is better named.

Without any context or history, I don't believe someone could successfully guess the roles or distinction between bats and bats-core.

I propose that bats-core be renamed as bats-support or bats-internal or bats-lib (ordered per my preference). Obviously project renames are dangerous and should be done rarely and with caution. It is for this reason I am raising this issue now, so that it can be done ASAP (if at all), before we hit 1.0.