Incorrect assumption about `/tmp` vs `/data` about code-compass

[ag91]

done, can you let me know if this addresses your issue? In case we can close this

[ag91]

right, so 3 new defcustom should fix this issue. Let me try

[sir4ur0n]

Thank you!

I am surprised by this change:
39fc323#diff-403bd57b4035bd6080ca58474a307ed13b4b3ac3e6642dbc918f711609ad8368R335

- (unless (or (not maat-jar-p) (file-exists-p (c/expand-file-name source-file)))
+ (unless (or (not docker-command-p) (file-exists-p (c/expand-file-name source-file)))

Shouldn't it be this instead?

(if (and (maat-jar-p) (not (file-exists-p (c/expand-file-name source-file))))

which, by the way, I think better carries the meaning: "If we use the JAR command for maat-jar, and the JAR is not in the download directory, then we download it".

What do you think?

From a user perspective, I think it also prevents users from providing/using their own JAR but that's a different problem (and to be frank, one that does not impact me 😅 )

[sir4ur0n]

Besides my comment above - which does not impact me - the problem seems to be resolved for me with the latest commit, thank you!

[ag91]

Thank you!

I am surprised by this change: 39fc323#diff-403bd57b4035bd6080ca58474a307ed13b4b3ac3e6642dbc918f711609ad8368R335

- (unless (or (not maat-jar-p) (file-exists-p (c/expand-file-name source-file)))
+ (unless (or (not docker-command-p) (file-exists-p (c/expand-file-name source-file)))

Shouldn't it be this instead?

(if (and (maat-jar-p) (not (file-exists-p (c/expand-file-name source-file))))

which, by the way, I think better carries the meaning: "If we use the JAR command for maat-jar, and the JAR is not in the download directory, then we download it".

What do you think?

From a user perspective, I think it also prevents users from providing/using their own JAR but that's a different problem (and to be frank, one that does not impact me sweat_smile )

Thanks, I confused myself. Right, I don't think there has been a user yet who wants to swap jars ;)