Permission issue while copying scripts about code-compass

[sir4ur0n]

Hm, actually this might only happen when using Nix: in the Git repository, scripts are already .rw-r--r--, but in the Nix store they are .r--r--r-- (which is to be expected). I'll see if we can add a non-invasive change to the file-copying logic to reset permissions correctly.

[ag91]

right, maybe it is just a matter of modifying the postInstall clause in your nix recipe no?

[sir4ur0n]

Hmmm no, all files in the Nix store are read-only, this is not negotiable or modifiable in any way 😅 This is a fundamental aspect of Nix.

I can think of 2 ways:

• stop copying the scripts, and instead just run them from the c/path-to-code-compass location
• we add a set-file-modes command after copy-file in c/copy-file. I think this would be transparent for non-Nix users

I think the first suggestion is the most sensible, right? Or is there a reason to copy/duplicate the scripts that I am missing?

[ag91]

mmm, I like the copying as you can see what scripts were used for your analysis in the artefact directory. Going to add the set-file-modes

[ag91]

hopefully this solves your issue

[sir4ur0n]

I think you missed c/generate-host-edge-bundling-html 😅 These also trigger an error on second execution

[sir4ur0n]

PS: I notice that from a fresh start (after I remove /tmp/code-compass-<REDACTED>):

• if I run c/show-coupling-graph, everything works as expected, including opening the browser
• if I run c/show-coupling-graph-sync (useful because with the async mode, the log messages are not displayed in *Messages* buffer), then it correctly generates all the files in /tmp/code-compass-<REDACTED> but it does not open the browser 🤔

Is that the expected behavior? 😅

[ag91]

I think you missed c/generate-host-edge-bundling-html sweat_smile These also trigger an error on second execution

those file shouldn't be executable as the browser should deal with them. What error did you get?

[ag91]

• if I run c/show-coupling-graph, everything works as expected, including opening the browser
• if I run c/show-coupling-graph-sync (useful because with the async mode, the log messages are not displayed in *Messages* buffer), then it correctly generates all the files in /tmp/code-compass-<REDACTED> but it does not open the browser thinking

Is that the expected behavior

expected: the async-run is opening the server. I used the sync analyses for debugging mostly. If I have time I will redesign that

[sir4ur0n]

those file shouldn't be executable as the browser should deal with them. What error did you get?

On second execution of c/show-coupling-graph-sync, c/generate-host-edge-bundling-html is executed a second time, which copies the edge-bundling files. So similarly to the other files, if they don't have the w permission, the second copying fails.

[ag91]

lol sorry, working on this in the evening means that I am very slow at understanding what is going on. I just needed read write permission. Fixed both issues you raised: thanks for spotting this through Nix.