Removing need to name the file like in the database about galaxy-integration-ps2

[Eremeir]

Works perfectly now, Thank you!
Near all the games have full media too, just Silent hill Origins and Shattered memories missing a background.

[AHCoder]

Bin more than gz because gz is just a compressed iso file but in this case if won't really matter because users would only use it for iso files. I might look into it when I have some time.

[NoShotz]

Reading directly from the ISO's would be a good idea if you ask me.

[AHCoder]

It's definitely the best way to do it but it has a couples of issues. This is the way PCSX2 does it but only for single iso's that you load. I would have to find a way to open the iso file, then do it for all of the ones in the folder and then still check the serial with the pcsx2 database. All of this for minimal gain and the possibility that it takes longer (maybe too long) to add the games. At the moment the only issue I see with naming the files as they are in the database is that Windows doesn't accept special characters.

[Geroyuni]

I tested reading it with pycdlib, seems speed isn't an issue (10 files, less than half a second). Do you think this is a good way to go for it?

Tbh, anything that is faster / more convenient than a user manually editing each file is an improvement in my book

[AHCoder]

You seem to have already done most of the leg work. It you've tested it and it works then create a pull request and I'll merge it. If you do just create a another function for your method so we have something to fall back on just in case.

Edit: I forgot to mention that it might not work for bin or gz files. You could look into that if you want to otherwise I would specify that this method works only for iso's.

[Geroyuni]

Consider that just a concept for the reading / converting to serial part of it, I'm not very comfortable with doing the full thing. I did forget about bin/gz, are they commonly used?

[AHCoder]

It's been implemented but I can't thoroughly test it because none of my roms are stored as iso files. I tested it on one and it worked but some couldn't be read. This is probably only an issue for me though because I reduced their size so some files might be missing.

[Eremeir]

All of my roms are ISO's and none of them get detected.

Both under default and iso options, I still can't get anything to show up.
Haven't tried Giant Bomb because I don't have an account.

[NoShotz]

I just tested it, and it did work, but not all of my games got proper info like images and stuff. All games were added to the library though.

https://i.imgur.com/pfNBvml.jpg
https://i.imgur.com/ANc0deb.jpg

[Eremeir]

Initial comment was on the last commit, but even with the newest commit I still can't get any to detect.

[AHCoder]

I just tested it, and it did work, but not all of my games got proper info like images and stuff. All games were added to the library though.

https://i.imgur.com/pfNBvml.jpg
https://i.imgur.com/ANc0deb.jpg

Pulling images, metadata etc. is on GOG's side, the plugin only supplies a name and id for the game.

[AHCoder]

Initial comment was on the last commit, but even with the newest commit I still can't get any to detect.

I'm not 100% sure but it looks like you have the plugin installed under a different user (your roms are under Eremeir and the plugin is under Matt Borek). By default the database is stored in

• %LOCALAPPDATA%\GOG.com\Galaxy\plugins\installed\ps2_1e814707-1fe3-4e1e-86fe-1b8d1b7fac2e\GameIndex.txt

In C:\ProgramData\GOG.com\Galaxy\logs there's a log for the plugin. Check for errors in that file or upload it here and I'll see what could be causing the issue.

[Eremeir]

They're the same directory, there are no other users on this machine. Windows just likes to abbreviate user filepaths.

plugin-ps2-1e814707-1fe3-4e1e-86fe-1b8d1b7fac2e.log

[Geroyuni]

Works here. Some games don't get data/images (or get partial data/images) but that might be just GOG as you said.

[AHCoder]

They're the same directory, there are no other users on this machine. Windows just likes to abbreviate user filepaths.

plugin-ps2-1e814707-1fe3-4e1e-86fe-1b8d1b7fac2e.log

It's an encoding issue. I've specified that Python should use UTF-8 instead of your system default. Try the latest commit and let me know.

[NoShotz]

I just tested it, and it did work, but not all of my games got proper info like images and stuff. All games were added to the library though.
i.imgur.com/pfNBvml.jpg
i.imgur.com/ANc0deb.jpg

Pulling images, metadata etc. is on GOG's side, the plugin only supplies a name and id for the game.

It works fine when I was using the giant bomb setting, so obviously there is something buggy
https://i.imgur.com/gFsejhI.jpg

I think it may be name related as Sly 3 - Honor Amongst Thieves became Sly 3: Honor Amongst Thieves when I switched it to use giant bomb, and it then has artwork and stuff.