ahutchings / kohana-modules Goto Github PK

Submodule system is awful. All going good until you need remove submodule..

To remove a submodule you need to:

Delete the relevant section from the .gitmodules file.
Stage the .gitmodules changes git add .gitmodules
Delete the relevant section from .git/config.
Run git rm --cached path_to_submodule (no trailing slash).
Run rm -rf .git/modules/path_to_submodule
Commit git commit -m "Removed submodule <name>"
Delete the now untracked submodule files
rm -rf path_to_submodule

And all other not standard adding operations became git conflict and problem hell.

Composer is better modern solution. You can just host composer.json for each branch with required modules list and build site on it.

And more important - it will force developers to add composer.json and add packets to packagist.

Kohana 3.4 will implement composer installation too by default.

https://github.com/kohana/database
The Name should be database

Currently when you visit kohana-modules.com, the default view is the list of all modules for all version of Kohana starting from 2.3 to 3.2. Most of the people don't see the distinction at first which creates unnecessary confusion over why modules aren't working.

I propose two things:

• First - set the default view from Any to 3.2, so modules for the most recent version of framework are being visible by entering the website
• Second - more visible linking to the per-version module (github's branches), because some modules don't use tags or use branching instead of tagging to support several versions of framework

Kohana 3.3.0 was released a couple days ago.

Can you guess who can't wait to start sending some pull requests with compatible modules?

Edit: Not sure if this is actually an issue for the kohana-modules.com repo...

Most of the new modules do not meet the standards Kohana, low quality code, not contain comments, for example: all modules by madeinnordeste, /mgalang/kohana-elasticsearch.

fix for madeinnordeste/kohana-net

Please add only "serious" modules, because the repository used junior programmers.

The site doesn't get updated as soon there's a new module here? It seems that the last update online is from almost 1 month ago. Consider using gh-pages to make it as quick as 10 min to become online 👍

The site attached to this repo is great. However, I can see a problem going forward with different kohana versions. Many of the modules I saw listed aren't maintained anymore, and won't work with kohana 3.1. I think you should maintain branches for each kohana version.