alekseykulikov / browserify-test Goto Github PK

Hiya @alekseykulikov ...

I've been intrigued by all the magic in browserify-test and looking to add the same.

However, I'm wondering whether you might be inclined to add support for plugins (like mapstraction which I finds works nicely with uglifyify to get minified distribution files with external source maps that preserve references to the original source files (so, e.g., Chrome can display them and potentially allow editing of them during debugging).)

I think it may also be nice to have a hook to both supply browserify args and write the intermediate stream to disk so that, e.g., while setting up browser testing, one can also ensure distribution files are kept up to date without an extra call to browserify.

Maybe your exported module in index.js could simply return b to allow for additional steps?

(Sorry if any of this is off base, as I haven't tried your code yet, but seems like it might work.)

While I reported my main concern already at testem/testem#1095 , this TDD issue is I think particularly critical with browserify-test as we always assume a bundle so I thought you might be interested in tracking it here as well. Note that passing debug: true with browserifyOptions is not currently sufficient as PhantomJS simply will not use the source map info.

My limited testing also seems to suggest that Safari (at least 10.0.3) will only preserve source maps if we change your monkey-patch of Server.prototype.serveHomePage to write the user's browserified bundle buffer to an external file. As mentioned in the referenced issue, even here in Safari (as opposed to PhantomJS), it doesn't list the source line numbers in test error reporting, but it at least lists the source maps in console. I'd also therefore like to know whether you'd be open to a PR to preserve those source maps?

Others have described Electron as more modern than PhantomJS.

If this is correct and means it is kept more up to date with the latest browser features than PhantomJS (because of its use of Chromium over Webkit?), I would think, assuming its features can be adequately tapped from Testem (and there is at least one type of Electron use case supported in Testem's examples), I'd think this would be best to support and set as the default.

I just keep running into problems with PhantomJS not supporting the latest XYZ feature and would love to see some way around this.

(And in case it may bear some relevance, I see there is this too: https://www.npmjs.com/package/electron-mocha )

Bonus: also for some reason order of tests is important, for some reason mocha test/index.js test/cli.js fails, because test/index.js haven't released 7357 port.