fs throwing on require breaks brfs about node-browser-builtins

[AndreasMadsen]

This is a really good usecase for not having a throw. However an actual roll back (git revert) seams like a bad idea, removing the line and change the tests to the opposite (tests that require don't throw) would be much better. Also this should be done for all the unimplemented modules not just fs.

Another solution would be to have a browser-builtins specific method there tells the unimplemented modules that they have been implemented in an untraditional way and shouldn't throw.

process.implement('fs');
var fs = require('fs'); // should not throw

I would prefer the first, since that browser-builtins specific methods makes porting things to the browser become a two way compatibility issue.

I will fix this tomorrow or in the weekend if no body else dose it before me.

[thlorenz]

I actually think a revert would be fine. I mean what would you test - that requiring a file with no code doesn't throw?

If reverting is not ok, my fix would be to remove the test and remove the line that throws (which is essentially a revert). If that is ok, I can do that today and hopefully get this published ASAP, as this will affect everyone using brfs as soon as they upgrade browserify.

In general, no builtin should ever throw when required. If you want to warn users of missing functionality you may throw when they call an unimplemented method, but not before that.
Otherwise lots of other things may break as well.

[AndreasMadsen]

that requiring a file with no code doesn't throw?

Yes exactly. Whatever implementation there overwrites fs should be able to require the fs module. If the fs.js file is removed (empty files are likely to be removed) that will also throw on require.

I can do that today and hopefully get this published ASAP, as this will affect everyone using brfs as soon as they upgrade browserify.

I can understand that, but please be nice. This is a big update and browser-builtins even got a major version bump and it is a basically unknown repository there get very little feedback so there ought to be some issues.

[thlorenz]

I get that later down the line you may want to add tests back in (for empty files), but at this point the test serves no purpose, so I hope removing it is ok.

I cannot see a way that not throwing could be a regression and/or break existing code. Also lots of code aside from brfs may break due to throwing (we may not be aware of it yet since some peeps may not have upgraded their browserify in a month).

Therefore I think this fixes regressions rather than introducing them and should be published as a patch to unbreak everyone who depends on brfs for instance.
So even if you have other plans on how this will work in the future I believe it is very important to provide this fix in the meantime.

[AndreasMadsen]

So even if you have other plans on how this will work in the future I believe it is very important to provide this fix in the meantime.

My plans are stability and maintainability, I think both are partially done by being strict about adding tests when something fail. Also I added a pull request there fixes all the unimplemented modules and the tests.