Comments (7)
You will have to include the shims manually, to have a shared thing this way will just add to the maintains. But why would you want pull these out, there are almost just copy and paste. The modules as dependencies we have are generally hard to implement and except for the API they have nothing in common with the nodecore source. If anything the timers
module should be pull out, since its an odd module too.
from node-browser-builtins.
Because modules should be self contained and live on npm :)
I actually removed the shims stuff per some discussions we are having to drop legacy support in favor of just recommending the use of polyfills.
from node-browser-builtins.
Have this working without shims and updated to latest node.js code
https://github.com/defunctzombie/node-util
The idea is that we can test them in isolation and they can be depended on without breaking if node versions change.
from node-browser-builtins.
Because modules should be self contained and live on npm :)
Well I agree. I'm just scared about the maintains when I upgrade the node version, with separated modules this will mean I/we have to supply pull requests to individual repositories instead of just one. This process is usually a lot longer and the complexity in the interdependent modules will also be higher.
from node-browser-builtins.
It sounds like you are making the argument that modules should live on npm except when you have to update modules :)
I think maintaining it will not be as bad as it seems and others can benefit from picking the modules they want for their projects.
If we agree that we don't care about shimming for legacy automatically then many things become way way simpler.
from node-browser-builtins.
If we agree that we don't care about shimming for legacy automatically then many things become way way simpler.
If that's the case then I will surly support this idea as the total maintains load will be much less than it is today.
It sounds like you are making the argument that modules should live on npm except when you have to update modules :)
As a general rule I will have to think long and hard about that, as it is hard to analyze one self. Especially in this case, since I like to think that I put load upon myself before others.
from node-browser-builtins.
Idea supported!
It sounds like you are making the argument that modules should live on npm except when you have to update modules :)
This one was hard. First of all I don't want to believe it. To believe that one puts loads upon one self rather than others is one thing, if its actually the case is completely different and almost impossible to reason about, as its very rare to get loud response from friends and enemies. I think this is especially the case when you are as young as me, you tend to think the entire world is against you. To separate my believes and reality in this case is definitely something I will have to focus on next year.
What I do know, is that it was 48+ hours process to get from 1.0.0 to 2.0.0 (the node version bump) and I don't see it become any different even for a simple node patch. That's a huge maintenance load (and very boring too) and the fact the browserify-buffer
implementation was incomplete (both in feature and legacy support) and was used by different core modules was quite a pain.
As there are almost no maintenance (just copy&past and fix timers, buffer, process references and a IE11 shim) I will of of course support this.
from node-browser-builtins.
Related Issues (20)
- querystring & url do not do what node core does HOT 2
- Publish HOT 5
- you get all the shims whether you want them or not HOT 9
- Add another maintainer HOT 5
- fs throwing on require breaks brfs HOT 5
- No checks for the presence of console HOT 5
- 2.x breaks browserify with multilevel HOT 10
- add a new empty module for "module"
- Traced problem with browserify back to browser-builtins. HOT 1
- Browser support policy HOT 20
- missing Travis-CI and saucelabs linking HOT 1
- npm publish 3.1.0 HOT 3
- question: change name? HOT 1
- Missing files? HOT 2
- Failing travis build HOT 3
- `process` should resolve to browser.js instead of index.js HOT 2
- Use external modules and fix them such that the tests passes
- https.js missing? HOT 2
- events.js is missing HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-browser-builtins.