2.x breaks browserify with multilevel about node-browser-builtins

[thlorenz]

If you need a test case:

git clone https://github.com/thlorenz/level-json-edit
npm install

# that will work
node example/build

npm rm -S browserify && npm -S i browserify

# that will break since now we use the latest browserify version with latest browser builtins
node example/build

[alexgorbatchev]

@AndreasMadsen this might be related to the update you made. Would you happen to have some time to check this out?

[AndreasMadsen]

I'm doing it right now.

[thlorenz]

@AndreasMadsen, @alexgorbatchev, @substack I created a more isolated test case

[AndreasMadsen]

@thlorenz So I tried running your code and what I get is:

Error: Cannot find module 'jsoneditor'

and this was running with your fork of browserify, so it can't the same issue you are mentioning.

If I comment out var JSONEditor = require('jsoneditor').JSONEditor; then it compiles fine both on your and the latest version of browserify.

[AndreasMadsen]

@thlorenz Oh, okay I will try that version then.

[AndreasMadsen]

@thlorenz I'm sorry your isolated test works fine too.

[thlorenz]

@AndreasMadsen you probably had an older browserify installed globally and npm start picked that up.
I changed the repro to pick up the local version.

However @substack discovered in the meantime that this was a browserify problem and fixed this.

So I'm closing this issue. It appears that [email protected] just happened to cause this issue to surface.

Thanks for your help.

This was an issue in browserify core related to cycles not being handled properly by the duplicate file hashing algorithm. This issue can be closed.

[alexgorbatchev]

Great, thanks for looking into this!