GithubHelp home page GithubHelp logo

am1codes / poke-dex Goto Github PK

View Code? Open in Web Editor NEW
143.0 4.0 382.0 19.34 MB

This is a small webpage that allows user to add their favourite Pokémons! This project aims to help people in creating their first pull requests and participating in Hacktoberfest 2021

Home Page: https://am1codes.github.io/Poke-Dex/

License: MIT License

CSS 1.37% HTML 97.84% JavaScript 0.79%
hacktoberfest good-first-pr html5 css3 pull-request first-pull-request opensource hacktoberfest-accepted hacktoberfest2021

poke-dex's Issues

Fix broken images

Replace Pokemon image files with urls to hosted images and remove unused image files.

Just visit the website once before Contributing

Before contributing, i request you to visit the website once to see the pokemons that are already there. There are some unique as well as repeated pokemons currently in the website but i would love to see more new ones. It's okay if your favourite pokemon is included and you still wish to contribute the same. But if that's not the case then please add new unique ones.

Thank You!

Add gif instead of photos

I can add gifs to the website instead of the photos which can make your website more attractive .

there are 2 entries to pokemon Gible

title.
after looking at source code, entries for Gible found in index.html, pokemon.js and pokemon.json (haven't looked at other files). could this be a cause of the duplication problem?

New Pokémon, More Fun

Hello, I'm new to open-source contribution.
This is my first pr so I'm requesting you to assign this issue to me under HacktoberFest.
Gotta Catch 'em All

Check for Redundant Entries

We should also look into making sure there are no redundant entries (i.e., only one instance of each Pokemon should be present in the Poke Dex

Layout Fixes

hey,there i have found some layout and alignment bugs. Shall I fix those??

Many Repetitions of Cards from same Contributors.

I merged a few PRs and didn't check the website but because of that there has been lot of redundant code added to it which needs to be removed. Carefully go through the website and when you are making a PR to remove a card, please attach the name of the contributor who's card you are removing along with a screenshot showing the multiple instances. You can also add images in the places where they are missing. And please avoid making PRs that have lot of redundant code.

Thank You.

Ability to sort cards

It could be helpful if a button was provided to sort the cads.
Since the pokemon number (#) can be used to identify a pokemon uniquely, maybe a sort button can be added with a dropdown for sorting cards according to their # (number) or name (alphabetically) and maybe default the sort to the order in which the cards were added.
New contributors can add the pokemon number along with the name and for existing ones maybe I can write a simple script which will fetch the pokemon api and add the required details in the existing cards.

Welcome Contributors!

Anyone and everyone is invited to contribute to this mini project. It's a very significant Pull request for anyone who wishes to contribute. Happy Hacking!

Add scale animation.

The pokemon cards' size should increase a bit when they're hovered over.

Hey @AM1CODES , I would like to add scale animation to the pokemon cards.

Creating New Designs for Pokedex

This is a call to all the designers who would like to contribute to this project. In the past 2 years, we were able to get a lot of code contributions to the repo, but for this year i wish to encourage designers to contribute to it as well and come up with some really good designs for the website that would go well with the Pokemon theme. Here's how you can contribute -

  • Design ideas/Wireframes
  • New High Fidelity Designs
  • Individual Card Designs
  • Product Ideas

Looking forward to seeing more designers contributing to this repo!

Please Don't Try to make the website Responsive

I really appreciate your efforts towards making this look better but the bootstrap that i have used helps in making this whole thing Responsive on its own. I suggest you to use the code template i have provided so that its easier for you to contribute as well as makes it easier for me to asses the changes. Once again, i dont wish to stop anyone but by mistake if you make some errors, then the whole website will be affected. Thank you

idea: add page for type chart

I had an idea for the website. A separate webpage for a type chart. A type chart is essentially a table which represents the effectiveness of a pokemon type against all the other typed pokemons. So, it's addition could be useful and neat. Presently, I just have the idea of having an centered image for this on the webpage type-chart.html .

Add Pagination

Can I add pagination to your website? There is a lot of data and scrolling which can be minimalized and give a nice look to the UI

I want to make it mobile responsive

Like the header and the text not aligned properly.
I want to work on it and make the changes

can you pls assign the task to me?

I am new to opensource and hacktoberfest

Suggestion: Remove duplicate Pokemon

The following are Pokemon that appear more than once in the Pokedex:

  • Pikachu
  • Bulbasaur
  • Squirtle
  • Charizard
  • Arcanine
  • Rayquaza
  • Gyarados
  • Tyrantrum
  • Caterpie
  • Psyduck
  • Eevee
  • Charmander
  • Jolteon
  • Greninja
  • Ho-Oh
  • Oricorio
  • Ninetales
  • Meltan
  • Xerneas
  • Unown
  • Mimikyu
  • Jigglypuff
  • Treecko
  • Kingler
  • Snorlax
  • Shuckle
  • Electrode
  • Dragonair
  • Crobat
  • Roserade
  • Diggersby
  • Rampardos
  • Chesnaught
  • Marowak
  • Komala
  • Sunflora
  • Bastiodon
  • Maractus
  • Chimecho
  • Leavanny
  • Wooper
  • Tsareena
  • Gigalith
  • Eiscue
  • Swoobat
  • Charmeleon
  • Metapod
  • Chimchar
  • Poochyena
  • Exeggutor
  • Duskull

Some duplicates were created by different users and some were created by the same exact user.
I propose we remove duplicate entries created by the same user.
Please let me know your thoughts, I'm happy to make a PR removing said duplicates.

image extension issues (jpg)

Some images are jpg files, so they are not consistent with other png images.
Changing this file to a png file will make your web page look cleaner!
캡처
!

Card size

Do you think we should set the card to a fix height? Think it would make the layout a bit cleaner.

Updating the Poke-card design

The current pokemon card designs are very uneven and do not look that eye catching I'm trying to improve the design. Please allow me to do so.

Description Hover Effect

Hello,
felt nostalgic after seeing this repository as it was one of my favourite shows. I want to add description hover effect without hampering the original card design/ website design as the present one looks uneven. This hover effect will bring evenness to site. I would be happy contributing to this project as am a beginner to open source contributions and hacktoberfest.

Excited to contribute {finger's crossed}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.