Ampersand Collection fails to prevent duplicate items about ampersand-collection

[HenrikJoreteg]

I believe setting mainIndex on the collection will fix that issue. But it's also possible we're not using that quite everywhere in the code.

It's also possible that it's not documented. So we need to address both of those. Thanks for filing this.

https://github.com/AmpersandJS/ampersand-collection/blob/master/ampersand-collection.js#L21

[mhuggins]

+1 on this issue. I have mainIndex set to a non-id value on my model, and I ended up with duplicates (that were exponentially duplicated) on saving collections because of this bug. I had to add this hack to all my id-less models:

derived: {
  id: {
    fn: function () {
      return this.name;
    }
  }
}

[HenrikJoreteg]

Thanks @mhuggins will investigate.

[HenrikJoreteg]

Turns out this happened if adding models with custom id attributes, but only if adding them as instantiated models. Anyway, fixed and published as to npm as a patch release v1.3.12. Thanks!

[mhuggins]

Thanks for the fix! I'm planning to work on upgrading some plugins this week, so I'll give it a shot. 👍

[mhuggins]

Out of curiosity from glancing at the code, it looks like there are a number of other places working with id rather than the collection's mainIndex or model's idAttribute. Just wondering if these might pose as an issue as well. Here are a few examples for references:

• Line 85
• Line 111
• Line 112
• Line 119