Comments (3)
After further investigation I found this: ariya/phantomjs#11090
Seems like for whatever reason phantomjs reverses the parameters passed into sort and this is something that might get resolved in phantomjs 2.0 .
So perhaps swapping the aforementioned lines might be the solution to this bug. Especially if you're not using phantomjs to run your automated tests.
from ampersand-collection.
This is an interesting one. I wonder if maybe it would be better to simply return 0
when both left and right are undefined.
from ampersand-collection.
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/sort
If compareFunction(a, b) returns 0, leave a and b unchanged with respect to each other, but sorted with respect to all different elements. Note: the ECMAscript standard does not guarantee this behaviour, and thus not all browsers (e.g. Mozilla versions dating back to at least 2003) respect this.
So I'm not so sure about return 0
. I can create a PR for my suggested fix it should be fairly low impact.
from ampersand-collection.
Related Issues (20)
- Fix performance issues in collections and subcollections HOT 10
- deIndex is being called wrong HOT 8
- -nothing-to-see-here- HOT 1
- Tracking collection state. HOT 13
- .get(id) can't find object with id 0 HOT 2
- .find(query, [indexName]) to retrieve multiple models HOT 4
- using ES5 `bind` for double argument comparator causes Phantom.js to fail HOT 2
- adding element with id:0 results in duplicates
- Upgrade from 1.4.2 to 1.4.3 causes jasmine tests to fail HOT 3
- Consistent sorting functions HOT 4
- Collection of Collections HOT 3
- index issue during collection.set
- Iterable via for...of HOT 1
- Document `parse` method HOT 1
- Collection does not sort itself when elements change HOT 4
- No good hook for when models are inserted
- No "update" event like in Backbone
- lodash helper do not support second parameter binding HOT 1
- Feature Proposal: "cancel" callback in fetch options? HOT 1
- When null is passed as value, it instantiates an empty model in the collection HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ampersand-collection.