GithubHelp home page GithubHelp logo

Comments (1)

jonahbron avatar jonahbron commented on June 19, 2024

For reference to anyone else who runs into this issue in the meantime, there are a couple of solutions; one is to ensure range is always checked.

  effect(() => {
    const range = this.range();
    this.calendarRef?.setInput('selected', range);
  });

But I felt that this solution could be brittle; someone (even myself in the future) could easily come along and think that factoring out that variable is okay. That could be defended against with a comment like this that standardizes the practice of evaluating dependent signals unconditionally:

  effect(() => {
    const range = this.range();
    // ^ Evaluate all signals first ^
    this.calendarRef?.setInput('selected', range);
  });

But the solution I settled on instead was to turn calendarRef itself into a signal. Then the optional chaining all works as expected.

  effect(() => {
    this.calendarRef()?.setInput('selected', this.range());
  });

from angular.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.