arminbiere / satch Goto Github PK

Just a quick heads-up: When compiling satch on 64-bit ARM Linux, some of the tests fail. The satch code assumes that char defaults to signed. On ARM, however, it defaults to unsigned.

Adding -fsigned-char to the compilation options fixes this.

(Well, strictly speaking, it's up to the compiler. But on ARM, compilers seem to chose unsigned.)

Dear Armin,

It is nearly irrelevant, but I believe there might be a small typo in a comment (features.h:73), where NQUEUE should be replaced by NHEAP.

Apologies if that is not the case, and thank you for this project!

in file satch.c, line 225 the text should probably be

... binary clauses can become completely 'virtual' and do not have to be stored at all ...

I've seen a CNF input that ends with the

-450 -480 0

without a newline.

Satch rejects this as incorrect (which sounds too harsh).
I think EOF should be allowed after the last digit of a literal (or 0 in this case).