arteria / django-compat Goto Github PK

Downloading/unpacking django>=1.4,<1.11 (from django-compat==1.0.13)

The blurb displayed at the top of this URL needs to mention Django 1.11:

https://github.com/arteria/django-compat

• import_module
• get_model
• add_to_builtins

so please adapt where applicable.

try:
    from django.db import close_old_connections as close_connection    
except ImportError:
    from django.db import close_connection # old Django version < 1.8

Private note:

• django-cronium
• django-background-tasks (see fork from kubic)

@jvamvas please check the forks of @SebCorbin and @kakky0312 - there seems to be an issue in setup.py

This GitHub project doesn't mention Django 1.10 in the blurb:

It needs to match the README file.

This also affects the blurb in https://djangopackages.org/packages/p/django-compat/

• http://django.readthedocs.org/en/latest/topics/templates.html#django.template.loader.render_to_string

• based on https://github.com/mysociety/mapit/blob/master/mapit/djangopatch.py#L4-L12

  """ Django 1.8 changed how templates operate. """
  import django
  if django.get_version() >= '1.8':
      from django.template.loader import render_to_string
  else:
      from django.template import loader, RequestContext
  
      def render_to_string(template_name, context=None, request=None):
          context_instance = RequestContext(request) if request else None
          return loader.render_to_string(template_name, context, context_instance
  

init() got an unexpected keyword argument 'safe'

Tests fail with

  File "/home/abuild/rpmbuild/BUILD/django-compat-1.0.15/compat/tests/urls.py", line 5, in <module>
    url(r'^accounts/logout/$', views.logout, name='logout'),
AttributeError: module 'django.contrib.auth.views' has no attribute 'logout'

Fairly simple to fix https://stackoverflow.com/questions/47065438/attributeerror-module-django-contrib-auth-views-has-no-attribute

warning: no files found matching 'LICENSE'
warning: no files found matching 'README.rst'
warning: no files found matching 'README'
warning: sdist: standard file not found: should have one of README, README.rst, README.txt

warning: check: missing required meta-data: url

warning: check: missing meta-data: either (author and author_email) or (maintainer and maintainer_email) must be supplied

https://github.com/evonove/django-oauth-toolkit/blob/master/oauth2_provider/compat.py#L34-L39

RemovedInDjango19Warning: django.utils.importlib will be removed in Django 1.9.
from django.utils.importlib import import_module

# -- import_module
from importlib import import_module

http://stackoverflow.com/a/29932043/485361

I'm getting the same issue as django-hijack/django-hijack#38. django-compat is returning a string argument where the get_object_or_404 function needs a model argument

The problem is over at https://github.com/arteria/django-compat/blob/master/compat/__init__.py#L162. Switching the try blocks so that django.contrib.auth.get_user_model is the first choice would solve my problem on 1.7. Don't know if it would break something on other versions though.

Hello,

i'm planning a sprint at pyconfr to build a django compatibility module, which wouldn't behave like an intermediate module (like six for py3k, or like django-compat for django), but directly monkey-patch django with log-lifespan shims.

Thus, django webmaster who want to upgrade wouldn't have to fork/monkeypatch all their broken dependencies, and minor django upgrades would REALLY be minor (i.e would NOT rename/remove methods and attributes used by tons of unmaintained libs).

Would you be OK with integrating this monkey-patching utility to django-compat, to have an all-in-one solution, for BOTH library maintainers and library users ?

The next version of Django is changing quite radically the way URLs are being included, by requiring an app name to be provided. One way to do it (and sometimes the only one) is to change the first parameter to a tuple.

It would be great if there could be a version of include in django-compat. It looks like the new syntax is available from 1.9, and the old syntax is no longer working from 2.0.

Would that be an acceptable change? I could try to put together a PR if so.

get_current_site has moved from

django.contrib.sites.models to django.contrib.sites.shortcuts

The method included to patch get_query_set is very broken, and leads to some very bug code in circumstances where managers get subclassed - the behaviour of the subclass can be skipped. This is a very serious error for the case of Related managers, because it means that the limiting of the queryset that is added by the subclass get_query_set method gets skipped, so the related manager queries apply to all objects.

I've created a branch that demonstrates the problem, adding 4 tests, 2 of which fails with Django 1.8, one fails with Django 1.5:

https://github.com/spookylukey/django-compat/tree/get_query_set_patch_bug

I've created a PR so that you can see the tests failing.

The full details are explained in this blog post:

http://lukeplant.me.uk/blog/posts/handling-django's-get_query_set-rename-is-hard/

Django 1.11 LTS will be the last Django version to support Python 2. The next major release, Django 2.0, will only support Python 3.5+. So Django 1.11.x will probably be the last supported version for LTS-to-LTS support of django-compat (1.8-1.11). See Django's release notes for more.

  File "/Users/Bruno/Documents/Workspace/open-source-projects/django-surveys/.tox/py36-djangomaster/lib/python3.6/site-packages/compat/__init__.py", line 388, in <module>
    from django.urls import (
ImportError: cannot import name 'LocaleRegexProvider'

From the updates in the tests in this PR, I'm under the impression that it was renamed to RegexPattern in Django 2.0a1.

These points should be better communicated in the README

• what version of Django is supported and unsupported anymore
• Version convention from django-compat to Django

Please note #17 as well that aims to show what works in wich version and if its tested.

This project's tests uses the imp module which has been deprecated since Python 3.4 and set for removal in 3.12:

• Raised PendingDeprecationWarning since 3.4 (2014)
• Raised DeprecationWarning since 3.5 (2015)
• Updated DeprecationWarning to say removal in 3.12 since 3.10 (2021)
• Removal planned for 3.12 (2023)

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

Just add another options to compat imports
django/django@16411b8

Draft

✔️ = compatible
⚠️ = basically compatible but has issues, eg. manual interactions, migration, ..
❌ = incompatible
✖️ = not supported by compat

I think use django-nose is a bad idea because it doesn't support Django<1.8.
So we cannot test this version with the ./runtests.py.

We should use Django test runner like made here: https://github.com/django-dbbackup/django-dbbackup/blob/master/runtests.py
It also allow to launch any commands like manage.py.

What should be added to compat? We currently use:

• GenericForeignKey

Source: here

from django.contrib.contenttypes.admin import (  # NOQA isort:skip
    GenericInlineModelAdmin, GenericStackedInline, GenericTabularInline,
)
from django.contrib.contenttypes.fields import (  # NOQA isort:skip
    GenericForeignKey, GenericRelation,
)
from django.contrib.contenttypes.forms import (  # NOQA isort:skip
    BaseGenericInlineFormSet, generic_inlineformset_factory,
)

From https://github.com/django-debug-toolbar/django-debug-toolbar/blob/master/debug_toolbar/compat.py