asottile-archive / api-gateway-v2-to-wsgi Goto Github PK

Just found this in my newsfeed. Is there a reason I would use this over e.g. https://github.com/Miserlou/Zappa (or at least over the parts of Zappa that deal with translation to WSGI)?

I just finished upgrading my similar package apig-wsgi to support v2. I used this library as reference. On the way I spotted a bug - the set-cookie header in responses does work, but if a response sets more than one cookie, you can only have one header, so the other cookies will get dropped. You need to pull the cookie headers out into the cookies return array.

Additionally ths library isn't returning the full response object (doc'd at bottom of this page), I'm not sure if there are potential issues there e.g. api gateway may try and infer if response content is base64 encoded (not documented ofc).

Hi -- I attempted to use this library yesterday and wanted to point out some issues that I encountered. These were both easy fixes and I like the lightweight nature of this library. I hesitated to open a PR or fork because I saw this was updated as recently as yesterday so figured it must be working for somebody.

1. This line causes an issue when body is set to None on the event (can't call encode None on line 69)

body_b = body.encode() if body else b'' # will do the trick on 69

2. The event structure seems to have changed in other ways too.
   • rawPath is now path
   • rawQueryString may not be present
   • request context no longer has an http key, now has an identity key
   • headers are not called multiValueHeaders
   • there are a lot of these type of changes, I won't enumerate them all

If others are running into the same issue I'll open a PR with the changes; if some are still using this successfully (perhaps for older versions of API v2?) I can open a PR that supports looking for keys in both formats.

presumably this is easy to implement I just didn't do it

my guess is that you'd put some code here and encode the response and set isBase64Encoded in the response

I didn't need this for my use case so I didn't implement it