b12io / kinase Goto Github PK

Proposal:

• AnnotationMapping -> AnnotatedItem
• AnnotatedItemField
• (eventually) AnnotatedItemCollection
• redux state should correspond to whatever names

Would be nice for our packaging command to auto-publish the new version to the Chrome webstore using its API.

Right now it's pretty confusing, largely because the proxy actions and their aliases are in separate files. We should package actions and their proxies together, or ideally automatically create proxy actions from their aliases.

The user should be able to provide an optional displayName parameter in the schema for each annotation, which should be read into redux and displayed instead of the annotation string if present.

Unsure why, but after compiling a test with the kinase-example repo, I see the above error.

Trace

Uncaught (in promise) TypeError: Cannot read property 'undefined' of undefined
    at selectors.js:49
    at index.js:76
    at index.js:36
    at index.js:90
    at index.js:36
    at index.js:86
    at index.js:36
    at Function.mapToProps (index.jsx:211)
    at mapToPropsProxy (wrapMapToProps.js:43)
    at Function.detectFactoryAndVerify (wrapMapToProps.js:52)

api.js

export function load(contextKey) {
  const schema = {
    "schemas": {
      "products": {
        "fields": {
          "name": "text",
          "description": "rich-text",
          "photo": "image"
        }
      }
    },
    "mappings": {
      "products": [],
    }
  }
  return JSON.stringify(schema);
}

export function save(updatedMappings, contextKey) {
  console.log(updateMappings, contextKey);
}

Any ideas?

Either get the shadow DOM stuff working with react or figure out an all: initial hack.

Currently, we reuse our internal webpack config to build derived extensions, which means we break the user's build on lint errors.

Ran into some issues when deploying 0.1.4, had to manually run np

Seems like it's not necessary, and should be a simple addition here:

Happy to write a pull request.