beanumber / teamcolors Goto Github PK

https://www.espn.com/college-football/story/_/id/35804245/cfb-conference-realignment-tracker-2023

We need to update a bunch of college team divisions.
2022 changes:
Marshall, Old Dominion and Southern Miss to Sun Belt.

2023 changes:
BYU, Cincinnati, Houston to Big 12
Charlotte, Florida Atlantic, North Texas, Rice, UAB, UTSA to AAC.
Jacksonville State, Liberty, New Mexico St, Sam Houston to CUSA

2024 changes:
Cal, SMU and Stanford to ACC.
Oregon, UCLA, USC, Washington to Big 10.
Arizona St, Arizona, Colorado, Utah to Big 12.
Texas and Oklahoma to SEC.
Kennessaw State to CUSA.

Team Colors website updated to have NCAA teams. Any chance we can get these into the package as well? Thanks!

Hello teamcolors contributors,

I'm developing an R package (bbgraphsR) that uses the teamcolors dataframe from your package in one of my functions (viz_standings), but either when running devtools::load_all() or devtools::check(), I receive the following warning:

Warning: object ‘teamcolors’ is not exported by 'namespace:teamcolors'

I indeed checked the NAMESPACE file and it makes sense because there is no line exporting that table.

In that case, can I save the table data and use it in my package?
Or is it expected to export that table in the future?

Thanks in advance for your feedback.

Regards.

Daniel.

Change Washington Redskins to Washington Commanders
Change Cleveland Indians to Cleveland Guardians

Some these color choices are weird. What's with the Yankees and Dodgers?

@gjm112

Ugh, this is going to require some name standardization. Maybe IPEDS can help?

I think Louisiana Tech has the wrong colors: https://brand.latech.edu/identity-standards/university-colors/

Primary should be: #003087
Secondary should be: #CB333B

Currently they are:
Primary: #E31B23
Secondary: #A2AAAD

I want to add colours for the Canadian Football League, but I have a few questions on the formatting.

1. Some teams (Montreal and Ottawa) have two names - an English name and a French name. Should I just add the English language name?
2. The league has many defunct teams (mostly due to the failed expansion into the US during the 1994-95) and different franchises existing at different times with the same name and city. How do you handle defunct teams? Is it safe to assume due the the lack of Hartford Whalers in the database that they are ignored?

Cheers

Hey @gjm112 I hear you are an Rtist. Can you use this package to make a hex sticker for teamcolors?

e.g., espn_id, etc.

Just thought I'd put this request in since the base teamcolors dataset will need to change to accurately reflect the Raiders move from Oakland to Las Vegas. Thanks for this package guys!

theme_teamcolors (team = "nym")

See comment in #25

e.g. theme_mlb(), etc.

https://github.com/dreamRs/fresh

Could we leverage fresh and usethis to write create_website("Boston Celtics")?

Hi, this question is either a bug or user error or both, so I wasn't sure whether to post it as an issue. Apologies if it is user error.

As recently as May 2021, I was able to change the labels on my ggplot with scale_color_teams(labels = my_vector_of_labels).

Here's a toy example and my work-around:

library(ggplot2)
library(teamcolors)

#Example data; subset of data from bkref.com
toy_data = data.frame(
  team = rep(c("BOS", "SAS"), times = 3), 
  year = rep(2014:2016, each = 2), 
  Win_Pct = c(0.305, 0.756, 0.488, 0.671, 0.585, 0.817), 
  teamname = rep(c("Boston Celtics", "San Antonio Spurs"), times = 3)
)

# Base plot
# Original plot used 37 seasons of data and all 30 teams, so shrinking the label size was critical
p = ggplot(toy_data, aes(x = year, y = Win_Pct, color = teamname)) + 
  geom_line(size = 5) # line size for clarity of issue
p

# What worked as recently as May 2021, but now does not
p + scale_color_teams(1, labels = toy_data$team)

# How the preceding plot was intended to look
p + scale_color_discrete(labels = toy_data$team, type = league_pal(lg = "nba"))

The Jets now have "Gotham Green" as their color.

https://teamcolorcodes.com/new-york-jets-color-codes/