benhoyt / ht Goto Github PK

Dear colleagues,

I am receiving the following error when compiling this program:

sles15-sp3-sca:~/hashtable # gcc ht.c -o ht
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: /usr/lib64/gcc/x86_64-suse-linux/7/../../../../lib64/crt1.o: in function `_start':
/home/abuild/rpmbuild/BUILD/glibc-2.31/csu/../sysdeps/x86_64/start.S:104: undefined reference to `main'
collect2: error: ld returned 1 exit status

Can you kindly verify? Thank you.

The iterator has an issue, "ht_iterator" returns the address of a variable allocated in the stack, so when it goes out of scope it becomes invalid.

Nice work though.

Cheers,
Nicola

Coming here from reading you excellent article and trying to implement this in Oberon-2.

I was wondering when the table expands there should not be any duplicate keys and
therefore the line: if (strcmp(key, entries[index].key) == 0) { in ht_set_entry is not needed.

We can just skip to next free slot?
Do I think right here?

if (size + size < size) {
return NULL; // size too big; avoid overflow
}

Maybe:
if (size > SIZE_MAX / 2) {
return NULL; // size too big; avoid overflow
}

Hi!

Thanks for your great implementation and explanation! I have a quick question: It seems like this hash table does not support keys of type int (or long, etc)? So key type is only char*, correct? Would it be hard to expand to support different key types?

Regards
Olle