bip32jp / bip32jp.github.io Goto Github PK

Connect arcbit wallet with brainwallet
https://github.com/arcbit/arcbit-brainwallet
Android

Mnemonic Code Converter

Hello guys!

First of all, nice work!

I write this to ask you to create QR codes aside generation of various addresses (private and public), not just for one only, if it is possible, of course.

One cool thing also would be adding a feature that scrambles and create random addresses like bitaddress.org (by randomly moving a mouse or typing keyboard letters).

Once again, thank you very much for your work!
Regards.
Bruno

Hello, @bip32JP you don't seem to respond to my comments on the closed pull request.

The test data you have listed is wrong. As we are building unit tests to test against the test data you supply, it is easy to see that your test data is invalid because it contains ideographic spaces.

As you can see in the BIP39 spec, the mnemonic sentence generated will always contain words separated by an ASCII space. I realise you are saying that people need to normalise the test data before using it but this is incorrect practice. Test data should ALWAYS be an exact match of what you expect the code to produce. If you leave that test data there with ideographic spaces and someone fails to normalise the test data and gets the code working to your test data that would be very bad.

Long story short, test data to be correct to the BIP39 spec can NEVER contain ideographic spaces as the code normalises all output. Therefore correct code will always fail your test data.

If you want to refute my claim, can you please show me the code in the reference client that outputs a mnemonic with ideographic spaces? Else please explain how it is possible for the reference code to produce data that matches your test output.

Hi,

Is it possible to standardise these test vectors with the English test vectors?

What I mean by that is https://github.com/Thashiznets/BIP39.NET is designed around the English test vectors and I have unit tests setup to test against the officially listed English test vectors here https://github.com/trezor/python-mnemonic/blob/master/vectors.json

You have provided an input called "salt" what is the salt in this instance? It is confusing me because the salt is all in Japanese, yet the specification explicitly tells us that the salt is created by concatenating the word "mnemonic" with UTF8-NFKD(passphrase) such that salt = "mnemonic"+UTF8-NFKD(passphrase). So it should not be possible to have an all Japanese salt as it needs to start with "mnemonic". If you have translated the word "mnemonic" into Japanese I believe this to be incorrect as a developer will not know the translation for "mnemonic" in each language, if such word even exists in another language, and as it is used as salt and never seen by the user, the salt should always start with the constant "mnemonic" that is my interpretation of the spec.

The specification also says that the word TREZOR is used as the passphrase (For English test vectors), again your salt is in Japanese so what have you done to make that salt I have no idea???? And having no idea means I cannot build tests to these vectors. I agree with using a Japanese passphrase instead of "TREAZOR", but please can you specify what the password is such that we can append "mnemonic"+UTF8-NFKD(passphrase) as is described in specification.

Thanks!!!!!!!

I need help ​I forgot my seed and password right now I'm really worried. I don't know which way to turn. Contact Support metamesk. No response. I'm helpless

วิธีเรียงลำดับ 12 วลีใน Metamask

Hi, man. First of all, thanks for your work.

Newbie here, I am struggling right now to use your tool, createp2sh, trying to understand how it works.

So, basically, "Enter redeem script" is for the redeem script, clear, "Send to?" is for the address, but "Enter scriptSig (solution)" is not clear to me, I've tried with the Hash160 of the redeem script address, but it's not getting me any coins, of course.

How do you know what to put in that second field? ("Enter scriptSig")

Thanks again.

I am trying to make my BIP39 implementation equivalent to yours, and I'm having problems with the japanese test vectors. Take the last test vector for instance.

The mnemonic is this:

うちゅう　ふそく　ひしょ　がちょう　うけもつ　めいそう　みかん　そざい　いばる　うけとる　さんま　さこつ　おうさま　ぱんつ　しひょう　めした　たはつ　いちぶ　つうじょう　てさぎょう　きつね　みすえる　いりぐち　かめれおん

And passphrase is this:

㍍ガバヴァぱばぐゞちぢ十人十色

The test vector says the seed should be this:

346b7321d8c04f6f37b49fdf062a2fddc8e1bf8f1d33171b65074531ec546d1d3469974beccb1a09263440fc92e1042580a557fdce314e27ee4eabb25fa5e5fe

However, I get this value:

3ef879ac8a919ffc89031ba706ec49fd4ced3bf7ef20bea786c3e6705db994c29dbcd73e324d5da910f41d3770ba4c76347dc4d00f26f3a245d971ff0e32828f

I suspected that this had something to do with spaces. I tried replacing the japanese space with the english space, however that did not fix the problem.

Furthermore, when I try to run your BIP39 implementation from node, I get the same value as my code, which is this:

3ef879ac8a919ffc89031ba706ec49fd4ced3bf7ef20bea786c3e6705db994c29dbcd73e324d5da910f41d3770ba4c76347dc4d00f26f3a245d971ff0e32828f

Any ideas what I might be doing that is systematically wrong? I have no problems with the english test vectors, only the japanese ones. Thanks!

Hi,
I'm trying to send a transaction on https://bip32jp.github.io/english/createp2sh.html , but it gives me an error message stating "the fees are too high, please contact support"
could someone help me please ?