bitpay / bitcore-message

Bitcoin Message Verification and Signing for Bitcore

BitPay Perl Client

Business::BitPay - BitPay API

Quick Start

See the guide.

DESCRIPTION

BitPay API documentation contents full description of API methods: https://bitpay.com/help-api.

SEE ALSO

https://bitpay.com/downloads/bitpayApi.pdf

AUTHOR

Sergey Zasenko, [email protected]

COPYRIGHT AND LICENSE

Copyright (C) 2013, Sergey Zasenko.

This program is free software, you can redistribute it and/or modify it under the same terms as Perl 5.10.

bitcore-message's Issues

Message methods should accept more argument types

For example, sign could check if privateKey is a String or Buffer and convert accordingly. I can add these, but I'll wait for #2 to be merged to avoid any conflicts.

broken image link at top of readme

image is trying to fetch from: http://bitcore.io/css/images/module-message.png but gets 404

Using with Bitcore

The sign method is giving me "bitcore.ErrorInvalidArgument: Invalid Argument: First argument should be an instance of PrivateKey" although I created the private key with bitcore. I believe the problem is that the bitcore-message module uses a different bitcore module internally then the one I created the private key with.

Can't verify testnet signature

I've been trying to verify the following testnet message/signature with bitcore-message, but keep getting this stack trace.

message: localhost:3000
address: mx5u3nqdPpzvEZ3vfnuUQEyHg3gHd8zrrH
signature: G4Bi9/Z7hF17MpE9t7Txm3n0aBH6yCVLFB1VWzkZRz17FxErgA/oOWmwXWYr6/ILlRCmeYjc8MeI8PQWYAElZY8=

Invalid Argument: Error: i must be 0, 1, 2, or 3
Error
    at Error.NodeError (/src/node_modules/bitcore/lib/errors/index.js:20:41)
    at Object.module.exports.checkArgument (/src/node_modules/bitcore/lib/util/preconditions.js:14:13)
    at Function.Signature.fromCompact (/src/node_modules/bitcore/lib/crypto/signature.js:41:5)
    at Message.verify (/src/node_modules/bitcore-message/lib/message.js:92:29)
    at authenticate (/src/server/helpers/authenticate.js:38:32)
    at Layer.handle [as handle_request] (/src/node_modules/express/lib/router/layer.js:82:5)

breaks if you use this with bitcore-lib-cash

If you use this with bitcore-lib-cash you will get issues when trying to sign.

In particular

 throw new errors.InvalidArgument(argumentName, message, docsPath);
      ^
Invalid Argument: First argument should be an instance of PrivateKey

This is because bitcore-message requires bitcore-lib not bitcore-lib-cash as a dependency. Thus they reference a different instance of PrivateKey

Simple fix is to change the bitcore-lib dependency to bitcore-lib-cash to proceed.

Just a pain if you run npm update/install, you will have to change this back each time.

Encryption/Decryption?

Is this module explicitly for signing/verification, or could we add encryption and decryption of messages?

[REQ] Add Segwit Sign/Verify support

Bitcoin issue 10542 discusses how to expand the current sign/verify functionality to include Segwit.

The basic idea is to expand the header byte to help identify the segwit address scheme

35-38 p2sh segwit pubkey (base58)
39-42 segwit pubkey (bech32)

The Trezor FW has already implemented this in commit b5f9a5

As bitcoin core is likely to implement this and Trezor already has, it would be useful to have it implemented in a block explorer too.

Make bitcore-lib a peer dependency

Solving all "include guard" headaches: bitpay/bitcore-lib#21

Support uncompress format

This code throws an error:

var privateKey = new bitcore.PrivateKey('5KYZdUEo39z3FPrtuX2QbbwGnNP5zTd7yyr2SC1j299sBCnWjss');
var message = new Message('This is an example of a signed message.');
var signature = message.sign(privateKey);
var verified = message.verify(privateKey.toAddress(), signature);

The problem: https://github.com/bitpay/bitcore/blob/master/lib/crypto/signature.js#L35

Error: More than one instance of bitcore-lib found. Please make sure to require bitcore-lib and check that submodules do not also include their own bitcore-lib dependency.

These 2 things dont want to work together:

var bitcore = require('bitcore-lib');
var Message = require('bitcore-message');

bitpay/bitcore-lib#153