blankname / vim-fish Goto Github PK

View Code? Open in Web Editor NEW

This project forked from dag/vim-fish

35.0 35.0 6.0 41 KB

Vim support for editing fish scripts

License: MIT License

Shell 0.09% Vim Snippet 6.21% Vim Script 93.70%

vim-fish's People

Contributors

Stargazers

Watchers

Forkers

novadev94 dragon9815 humpangle mk12 nathanchance ian-h-chamberlain

vim-fish's Issues

errorformat for compiler feature does not work

Hi,
nice to see this plugin get some love again!
I'm currently trying to develop some fish scripts, and I noticed that the error format doesn't fit with the actual error messages.
The error format is
errorformat=%Afish: %m,%-G%*\ ^,%-Z%f (line %l):%s
but I get this error message:

integrator.fish (line 24): Missing end to balance this if statement
if nope
^
warning: Error while reading file integrator.fish

which just fills the quickfix list with 5 lines.

If I understand this correctly, this problem has been known since 2013 by the original author of this plugin:
fish-shell/fish-shell#539
and embarassingly, the feature still doesn't exist on the fish side of things.

So if I understand this correctly, there's currently nothing we can do in this plugin, so it would be good to add a note to the documentation, so the next guy doesn't have to waste half an hour to track this down, like I just did :)
(Unless you have in the meantime solved this riddle and there's just a little setting I'm missing, in which case I'd be grateful if you could share that secret...)

Status

Since @dag is less active with vim-fish I decided it would be a good learning experience to try maintaining a fork and merging some prs.

Merged:

dag#48
dag#25
- Merged the ftplugin change and not the added support for fish -p output files (although I could probably be convinced to merge that too, just need to think about it a bit more).
dag#29
- Fantastic improvement! Thanks @Raimondi

Not merged:

dag#46
- Went with dag#46 as it was more comprehensive.
dag#47
- Made a different change that covers any number of backslashes + quotes correctly.
dag#24
- See comments on the merge of 25.
dag#43
- This doesn't seem to be needed (the ftdetect autocommands don't seem to get doubled up).

Need to revisit:

dag#44
- Originally I thought this was working without their change, but it turned out I had a plugin that was causing the desired behavior. I'll look into it again when I get the chance.

I've added a few other very minor miscellaneous changes as well (so feel free to browse the commit log).

Thanks @dag for creating vim-fish and all of the others for their contributions.

Fold isn't working, could use some docs, or even just a few code comments on how it's supposed to work

visual mode range select + zf fails with 'Cannot create fold with current foldmethod', no matter what I set foldmethod to in init.vim. I wish I had more to go on, sorry.

NVIM v0.4.4
Build type: Release
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/cc -g -O2 -fdebug-prefix-map=/build/neovim-u4YhjF/neovim-0.4.4=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=1 -DDISABLE_LOG -Wdate-time -D_FORTIFY_SOURCE=1 -O2 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/build/neovim-u4YhjF/neovim-0.4.4/build/config -I/build/neovim-u4YhjF/neovim-0.4.4/src -I/usr/include -I/usr/include/lua5.1 -I/build/neovim-u4YhjF/neovim-0.4.4/build/src/nvim/auto -I/build/neovim-u4YhjF/neovim-0.4.4/build/include
Compiled by [email protected]

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

:checkhealth

health#coc#check
========================================================================
  - OK: Environment check passed

  - OK: Javascript bundle build/index.js found
  - OK: Service started

health#LanguageClient#check
========================================================================
  - OK: binary found: /home/xxxx/.config/nvim/plugged/LanguageClient-neovim/bin/languageclient
  - OK: languageclient 0.1.161
  - OK: Floating window is supported and will be used for hover

health#nvim#check
========================================================================
## Configuration
  - OK: no issues found

## Performance
  - OK: Build type: Release

## Remote Plugins
  - OK: Up to date

## terminal
  - INFO: key_backspace (kbs) terminfo entry: key_backspace=\177
  - INFO: key_dc (kdch1) terminfo entry: key_dc=\E[3~
  - INFO: $VTE_VERSION='6200'
  - INFO: $COLORTERM='truecolor'

health#provider#check
========================================================================
## Clipboard (optional)
  - OK: Clipboard tool found: xclip

## Python 2 provider (optional)
  - INFO: Using: g:python_host_prog = "/usr/bin/python2"
  - INFO: Executable: /usr/bin/python2
  - INFO: Python version: 2.7.18
  - INFO: pynvim version: 0.4.1 (outdated; from /usr/local/lib/python2.7/dist-packages/neovim)
  - WARNING: Latest pynvim is NOT installed: 0.4.2

## Python 3 provider (optional)
  - INFO: Using: g:python3_host_prog = "/usr/bin/python3"
  - INFO: Executable: /usr/bin/python3
  - INFO: Python version: 3.8.6
  - INFO: pynvim version: 0.4.1 (outdated; from /usr/lib/python3/dist-packages/neovim)
  - WARNING: Latest pynvim is NOT installed: 0.4.2

## Ruby provider (optional)
  - INFO: Ruby: ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-linux-gnu]
  - INFO: Host: /usr/local/bin/neovim-ruby-host
  - OK: Latest "neovim" gem is installed: 0.8.1

## Node.js provider (optional)
  - INFO: Node.js: v13.14.0
  - INFO: Neovim node.js host: /home/xxxx/.node/lib/node_modules/neovim/bin/cli.js
  - OK: Latest "neovim" npm/yarn package is installed: 4.9.0

Slow startup time

Firstly, thanks for the fork!

I'm using this fork as part of the vim-polyglot plugin. I'm seeing really long startup times when opening fish files. Looking at the startuptime log, I can see that it's slow due to sourcing the fish syntax file. I've tried removing vim-polyglot and installing this fork directly and I still see the same issue.

Not sure if you have any ideas on how I could debug this further?

Neovim Version

NVIM v0.5.0-dev+1089-gdc3ca16a9
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

Startup time log

Strangely, it seems like it's sourcing the file 3 times during startup and it's taking roughly 1.5 seconds each time.
These logs are from installing the plugin directly instead of through vim-polyglot

1744.123  1634.145  1634.145: sourcing <removed>/.local/share/nvim/site/pack/packer/start/vim-fish/ftplugin/fish.vim
3288.826  1457.445  1457.445: sourcing <removed>/.local/share/nvim/site/pack/packer/start/vim-fish/ftplugin/fish.vim
4775.268  1478.543  1478.543: sourcing <removed>/.local/share/nvim/site/pack/packer/start/vim-fish/ftplugin/fish.vim

blankname / vim-fish Goto Github PK

vim-fish's People

Contributors

Stargazers

Watchers

Forkers

vim-fish's Issues

errorformat for compiler feature does not work

Status

Fold isn't working, could use some docs, or even just a few code comments on how it's supposed to work

Slow startup time

Neovim Version

Startup time log

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

Jobs