GithubHelp home page GithubHelp logo

blockchain / unused-my-wallet-iphone Goto Github PK

View Code? Open in Web Editor NEW
129.0 35.0 54.0 35.18 MB

For latest source, please see: https://github.com/blockchain/My-Wallet-V3-iOS

Home Page: https://blockchain.info/wallet

License: GNU Lesser General Public License v3.0

Objective-C 13.38% C 16.57% C++ 3.80% Objective-C++ 0.95% JavaScript 0.18% HTML 2.37% Makefile 0.08% Shell 0.64% Assembly 61.38% Java 0.66%

unused-my-wallet-iphone's Introduction

Source Code License: LGPL v3

Artwork & images remain Copyright Ben Reeves - Qkos Services Ltd 2012

To Build:

# setup submodules - ssh pub key has to be registered with Github for this to work
git submodule init
git submodule update
cd Submodules/My-Wallet 
git checkout master
cd ../OpenSSL-for-iPhone  
git checkout master
./build-libssl.sh

# open the project in xcode
cd ../../
open Blockchain.xcodeproj

# build the project
cmd-r

Security issues can be reported to us in the following venues:
* Email: [email protected]
* Bug Bounty: https://www.crowdcurity.com/blockchain-info

unused-my-wallet-iphone's People

Contributors

dgarrett avatar grzaks avatar keonne avatar kmhouk avatar kristovatlas avatar kwgithubusername avatar mpfluger avatar stequald avatar tuzzolo avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

unused-my-wallet-iphone's Issues

URI handling

Bitcoin: links currently go to another app on my iPhone. Is URI handling supported?

Can't not download

Hello
I try many time download iphone app from your link
and it show:
The item you've requested is not currently available in the Vietnamese Store.

So how to i can install in my phone ?

Thanks you

APIDefines.h missing

Probably a beginners question. I try to compile the app myself, but during compilation, I get the following error:

My-Wallet-iPhone-master/Blockchain/RemoteDataSource.m:19:9: 'APIDefines.h' file not found

I noticed that this file is in .gitignore. Is there another way I should have this file already?

Thanks,

Jasper

IOS application currency defaulting to USD.

This is an issue that has been intermittent for over a month. When can we expect a patch, codechange, fix to remedy it?

The IOS wallet defaults to using the dollar as its default currency - despite going to the settings and switching it - it cannot implement/save the changes made

How long til this is fixed? .

Stuck on one screen

I initially had an issue paring the device. After deleting and reinstalling the app, and after adding a transaction (transferred BTC to my BlockChain account using a web browser), and after quitting and relaunching the app, it finally paired with my account. I'm not sure what really made the difference.

But now, when I launch the app, there's a very quick loading screen, then I'm stuck on a page showing 1 transaction (8 confirmations). The 2 apparent buttons at the top corners, and the 4 buttons at the bottom don't do anything (the left piggy bank button appears to be for the screen I'm stuck on). It's almost like a static screen shot, in that nothing I do give any feedback, or changes the screen. Hard reset doesn't help.

I again tried deleting the app and repairing again, and again getting stuck on pairing (quitting the app and restarting it seemed to get me paired), but I'm still stuck in the same screen (but showing more confirmations). Note that it seems each time I quit the app, then relaunch it, the app crashes at first relaunch, then loads the second time. I'm using an AT&T iPhone 4S with 32GB memory (1.1GB free) and the current iOS (6.1.3). I'd love to use this app, but it seems I've tried everything I can think of... Please let me know if you have a clue what I can try, or if there's any other info I can furnish.

Javascript 11 months behind

The Javascript used by this app is almost a year older than the Javascript used by the web app. This may explain why some people are getting error messages.

In my case I'm getting the mysterious error "Cannot ask for private key without user interaction disabled" when I try to send money. Since that error occurs in signer.js I tried replacing that file with the latest version from the web app, but that causes a new error because it can't find MyWallet. That in turn is defined in wallet.js, which I was able to add to the project.

However that didn't magically solve the problem. A lot seems to have changed in these javascript files and I don't fully understand how the javascript interacts with the rest of the app, so I don't know how to proceed.

I think it would be a good idea to put common code from the web and iOs client into a separate repository which is then used as a git submodule.

Stuck on "Okay" pop-up.

When either manually logging in or automatically, it takes you to the part where you would type in a pass-code. But here, the prompt is stuck there.

Lower the transaction fee and let the user decide

Currently Blockchain lets the user decide if they want a a High, Standard or Low fee, that means this:

0.00050000 High - (a.k.a. you are paying 30 usd cents)
0.00010000 Standard - (chosen by default)
0.00000000 Low - (a.k.a. no fee)

I have tried using lower fees and the experiment has been sucessful.

3eb8d739588afe7f782061a53b4563a3fdbbd772ec90c3c00d19c18bcb54e268
0.00004000  4 minutes to confirm

3527a730cbc546a7cf1b11da064331036bd9003ad539f29d89f03567281df616
0.00004000  3 minutes to confirm

1a5b81554908ee5ae0528b49b2714814cbe937b3cb20adefd0b3c257c767f02c
0.00004000  2 minutes to confirm

ebe37ee839ee3e3e7eea6011bf6e51d817883fbe2651fb58f2c844b20ddae9c0
0.00005000  3 minutes to confirm

9a9d6e48e3dd464fcf8f67783caf86d5a7ffb7c3cbc809fb95b81bda6e300243
0.00004000  4 minutes to confirm

584bb62cbda89fbe1d8da909963350471d5c6188416332c4989d1c850c266039
0.00005000  8 minutes to confirm

It seems that if you include a 0.00005000 BTC fee the transaction will get the first confirmation as fast as the standard fee.

So I propose this fees for Blockchain:

0.00020000 High - (12 usd cents)
0.00010000 Mid - (6 usd cents)
0.00005000 Standard - (3 usd cents)
0.00000000 No fee - (not recomended)

This update should make the average user pay the 0.00005000 BTC fee.

Also the fee selector should be visible in the send transaction dialog and the standard fee should be recommended.

Only when using the "no fee" option the user should be warned about the confirmation times.

no transaction fees

All my transactions are being sent with no fee and thus take very long to confirm. I see no way to set a transaction fee in the app.

PIN code security error

In my iPhone Blockchain wallet app, when I change the PIN code from within the app, it asks me for my current PIN, then the new one, then the new one again to confirm.

I can type any four numbers as my current PIN, correct or not, and it will accept it and change my PIN to the new one regardless.

In other words, I don't need to know my PIN in order to change it, which causes a minor security problem for people who tend to leave the app running.

wrong delimiter in bitcoin uri amount, ',' instead of '.'

When displaying a payment request, the data is not BIP 0021 compliant. Besides the // which is already somewhat annoying, the amount displayed uses a comma instead of a point as decimal delimiter, thus having BIP 0021 compliant apps fail to read the data.

This could maybe depend on the locale specific decimal separator, and thus vary depending on the users locale setting.

Transaction fee is too high

I've noticed a transaction fee of 0.5 millis on a transaction I made with the app, expecting it to only be 0.1 millis. Digging through the sources I found this:

//Priority under 57 million requires a 0.0005 BTC transaction fee (see https://en.bitcoin.it/wiki/Transaction_fees)
if (fee_is_zero && forceFee) {
    //Forced Fee
   self.fee = BigInteger.valueOf(50000);

source: https://github.com/blockchain/My-Wallet-iPhone/blob/master/Blockchain/js/signer.js#L412

However, that calculation is outdated, it should now be 0.1 millis, see https://bitcointalk.org/index.php?topic=219504.0

IMO it's really important to update this, as bitcoin price goes up, those transaction fees are becoming a problem.

iPhone App, set a new wallet

Hello,

it is not possible to log out of the iPhone app and set a new Wallet account.
Is it possible to include that?

Simon

Hangs on sending payment

I scanned a QR-code for the address, and added an amount in BTC (switched between BTC and EUR a few times, if that matters). I didn't add the address to my address book, and I confirmed the transaction. Now the app is stuck on the popup with title "Sending Payment" and text "Pushing Transaction". I can see (not in the app) that the payment has been executed already, it has several confirmations by now. I had to kill the app to get it working again.

App sends 6dp instead of 8dp

When I scan a qr code with an amount accurate to 8dp, only 6dp accuracy is sent.

eg a transaction for 0.00123456 BTC will only send 0.001234 BTC leaving the remaining 0.00000056 BTC unresolved.

Unable to scan QR codes

When on the send payment tab, tapping the camera icon brings up a modal with a black background but the camera does not appear to work. I've only tested on iOS 8.

If I use the app "Scan" to scan the QR code the Blockchain app correctly opens with the Bitcoin address pre-populated.

cannot pair device

if i try to, i get "no Data .. There may have been an error contacting our server. Please check". My Adreses shows "No Adresses..". But if I switch to account details, I can see my account correct. The email, the shortlink, all seems to be perfekt. but I can neither see my BTCs nor I can do some transactions. I tried to logout and login, install, deinstall, reset the whole iphone - nothing changes the situation.

Blockchain app no longer syncs with wallet

iPhone app has stopped syncing with Blockchain.info wallet. Issue reported as a problem decrypting the wallet. Deleting app and reinstalling has not helped. Issue seemed to arise when I changed my security settings on Blockchain.info site.

Bitcoin wallef

I need this money in my possession, it's been locked into the Tor browser for months now

Error invalid Bitcoinadress -> App shut down

Can you please help me to get acces threw the IOS App?
If I want to enter the passwort the German message: "Error: ungültige Bitcoin-Adresse" (engl.: Error: invalid Bitcoinadress) pops-up and the App close automatically.
If I enter a wrong Passwort i get a different error message (Error wrong Passwort).
Can you please help me to get access to my Bitcoins?!
What's wrong
As you can see here is a bug
Please help me

I cannot see all transactions

I've imported a private MultiBit key and can see transactions for the corresponding address with the iPhone app. However, I only see the most recent transactions, approx. 10-15. Why don't I see all transactions?

Piggy bank icon tab shows only “No Data”

Using the app version 1.9.9 from Cydia, the tab for the “piggy bank” icon always says “0 BTC / 0 Transactions / No Data: There may have been an error contacting our server. Please check your account is correctly setup and you have an active internet connection”

I’m not sure what it’s supposed to show exactly, but my internet connection is fine and as far as I can tell my account is correctly set up.

PIN entry is not accessible using VoiceOver

When creating and confirming a PIN, or using a PIN to unlock a wallet, the PIN entry is not visible at all with VoiceOver. I can swipe left to right and hear that I must enter or confirm my PIN, but the number pad is neither visible by swiping around the screen, ore by tapping directly over the numbers.

I am using IOS 8

Dynamic Fees

Hi, various wallets (breadwallet, electrum, bitcoin core, ledger, mycelium, copay, bitgo) now have dynamic fees integrated by default. This is essential to help deal with future stress tests / spam attacks, one of which is impending (Coinwallet's plan to create a severe 30-day tx backlog in September).

What are Blockchain.info's thoughts? It may be prudent to prioritize this and have it out ASAP, given that September threat... for all wallets: iPhone, Web, etc.

Thanks.

Sound Payments

I think it'd be awesome if sound payments were added via an API like Illiri. This could happen on the receive coins screen to allow payment apps like PoS systems send a sound with an encoded bitcoin URI. It could also be integrated into the send coins screen. This took me about 10 minutes to integrate into my bitcoin PoS app, and it'd be great if a wallet supported the tech.

Resources:
http://www.illiri.com/sapi/android/doc/index.html
http://www.illiri.com/sapi/sapid.pdf
http://www.illiri.com/

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.