brpoplpush / brpoplpush-redis_script Goto Github PK

Recently I updated my bundle which resulted in updating redis to "5.0.0". As you may know this version does not work with Sidekiq < 7. There is a fix for it in redis 5.0.1 but this is against dependencies constraints for this gem. Is there a purpose for it or it can be easily updated? :)

I experimented a little with it but couldn't find a way to add the project. It seems impossible for some reason.

When Sidekiq configured use redis namespaces like this

opts = {
  host:      APP_CONFIG[:redis_host].to_s,
  namespace: REDIS_NAMESPACE
}

Sidekiq.configure_server do |config|
  config.redis = opts
end

Sidekiq.configure_client do |config|
  config.redis = opts
end

Deprecated text appears at startup

Passing 'script' command to redis as is; administrative commands cannot be effectively namespaced and should be called on the redis connection directly; passthrough has been deprecated and will be removed in redis-namespace 2.0 (at /usr/local/rvm/gems/ruby-2.6.3/gems/brpoplpush-redis_script-0.1.1/lib/brpoplpush/redis_script/script.rb:69:in `load')
Passing 'script' command to redis as is; administrative commands cannot be effectively namespaced and should be called on the redis connection directly; passthrough has been deprecated and will be removed in redis-namespace 2.0 (at /usr/local/rvm/gems/ruby-2.6.3/gems/brpoplpush-redis_script-0.1.1/lib/brpoplpush/redis_script/script.rb:69:in `load')

We should update the README.md with some usage information. It would also be great to add some badges to the readme from https://travis-ci.com (build status), https://codeclimate.com (test coverage + quality)

Like you suggested in #1 we should allow various paths and scripts to be added to the gem. Right now it just takes a dumb directory because that is what I need to be able to use it in sidekiq-unique-jobs.