Comments (3)
Hey Cyril, I think you're right that the call to newFieldList
in generated TS can impact tree-shaking:
I believe that adding a /*@__PURE__*/
annotation right before the call expression should help (see #470 for reference).
But before we make this change, we need to verify that it actually works as expected (previous changes were tested with https://github.com/connectrpc/examples-es/tree/main/bundle-size). This will take us a bit to look into, but it looks worthwhile to me.
Thanks for filing the issue!
from protobuf-es.
Hi @liril-net. We tested adding this annotation to the newFieldList
call, but we aren't seeing any effect with Rollup (or most other bundlers). The only bundler that sees an improvement is esbuild. The PR we're using to test is here.
Are you noticing anything different with Rollup? Or do you see anything missing from how we are bundling in our tests?
from protobuf-es.
Let's close this. See connectrpc/examples-es#1499 (comment) for details.
from protobuf-es.
Related Issues (20)
- Get T property of FieldInfo HOT 3
- Expose message class's canonical name HOT 4
- Support option retention in @bufbuild/protoplugin HOT 2
- Regression: enum strings are broken in constructor of message types in 1.8.0 HOT 3
- Using message as a value in Map seems to break deserialisation HOT 2
- Values missing if set to 0 and after converting toJson() HOT 2
- Upgrade TypeScript to v5 in `@bufbuild/protoplugin` to reduce install size for users HOT 3
- Support for `google/api/field_behavior` ? HOT 1
- Incorrect typing of Struct.toJson() HOT 3
- v2 Access HOT 2
- getEnumType doesn't work when SSR HOT 3
- Fix Node10 subpath fallbacks
- Remove internal fields HOT 14
- The import is not working HOT 2
- Better terminal logs HOT 4
- Cannot encode field to JSON HOT 5
- @bufbuild/protobuf proto3 serialization regression: throw error when serializing oneof property with `undefined` value HOT 3
- Tree-shakeable enums HOT 2
- `PlainMessage<Empty>` is `{}`, meaning any non-nullish value HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protobuf-es.