calesce / redux-slider-monitor Goto Github PK

I tired to not add "keyboardEnabled" property to not listen for keyboard events, but it doesn't help. CTRL + J still replays the actions.

Well I don't think this is a good idea. I have like a text editor in my app and suddenly I cannot even type a space because you eat it up in there :) Same for those arrow keys.

Edit: Perhaps there should be a global key first to enable/disable these keyboard shortcuts. Anything too simple is just problematic to collide with developed app.

Love this kind of monitor. It is what you need 90% of the times, well done. I'm currently building an app using React 0.14 beta and it is giving some warnings about getDOMNode and findDOMNode. Are there any plans to make it 0.14 compatible?

The handle point appears in the wrong position when I resize window.

Hi,

when there's no state sequence recorded yet and I click play button I get en error:

Cannot read property 'state' of undefined

This error is also in your example: https://calesce.github.io/redux-slider-monitor/

O.

When I try to run the todomvc, it fails, because the react-hot-loader is expired and has a bug.
http://stackoverflow.com/questions/40652327/module-not-found-error-cannot-resolve-module-react-lib-reactmount

Hot loader need to be updated.

I noticed the live feature is gone. This was really helpful for me. Is there a particular reason why this was removed?

Could you please publish changes to npm? The current 1.0.0 has bottom padding for the elements except slider bar, so it goes bellow the arrows (I guess it is because I don't use DockMonitor). It is fixed here, but not released yet.

Is there any intention to add support for the latest version of React?

Thanks

Makes replay more realistic, could be useful for animations. Currently there's just a static setInterval jumping to the next state every half second.

Options could be something like: Real time (variable), Fast (every 100ms), Medium (every 500ms), and Slow (every second). Will need to add some sort of <select/> element.

I saw your interest with replaying app like cerebral can. This works especially cool with your slider monitor, but I think that export/import of actions/state can be used for a lot of things not only for this use case. So maybe we can collaborate to make redux-export-import-monitor happen, what do you think?

As the title describes - cannot hide/show the monitor with ctrl-h.
I notice you check for process.env.IS_BROWSER, which isn't set when I check it in my app. Is that a node-specific thing - would it be possible to make the keyboard check a bit less environment specific? The LogMonitor in devtools checks typeof window !== 'undefined' - maybe that instead?

Redux DevTools beta is out with breaking changes. For monitors, there are a few of them:

• Instead of receiving action creators in props, you now get dispatch in props and have to import { ActionCreators } from 'redux-devtools' to get access to commit, rollback, etc
• The action props are now indexed by ID, so instead of stagedActions and skippedActions you get actionsById, stagedActionIds and skippedActionIds. toggleAction() now accepts id instead of index. To grab vanilla action object by ID, use this.props.actionsById[id].action. The timestamp is also available on that action: this.props.actionsById[id].timestamp.
• The monitor now has to export a reducer static property. For what it's worth, it could be a no-op function, but it must exist. In more interesting case, it will be (state, action, props) => nextState function where state is the monitor's own state available to it as monitorState prop. You are free to use it to let monitor react to any action and remember any data. This is why setMonitorState prop is gone.
• Monitors shouldn't take care anymore of isVisible (hiding or showing themselves) or doing so on special key presses. We're moving towards a composable monitor model, where you'd use a special dock monitor to contain other monitor. Therefore monitors should only be worried about rendering themselves.

The diff of the default LogMonitor can serve as an inspiration for these changes.
You can try the new version of Redux DevTools on the next branch.

Please let me know if you find any issues. The API might change slightly in the final release, but this is pretty close, and it involves some work, so let me know if you need any help.

Have the slider use the themes added in 1.0 of DevTools.

Hi,
when I click on filtering links, no new state is created, so you can't "time travel". Isn't it a buggy behaviour?

I'm getting a warning in Chrome about an unknown property:

Warning: Unknown prop `fit` on <svg> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
    in svg (created by SliderButton)

Looks like it's coming from the SliderButton