coatue-oss / slickgrid2 Goto Github PK

Otherwise we end up calling this method twice, and it's bad for perf

Can't think of a case where we would not want this to happen.

Otherwise the consumer has to add logic to store and re-set the active cell after calling grid#setColumns and grid#refreshColumns

1. Pin the 1st column
2. Click on any cell
3. Use right arrow key to move all the way to the last column in the grid
4. Now use the left arrow key to go all the way back to the first column

Expected: First non-pinned column should scroll into view
Actual: First non-pinned column is occluded by the pinned column

triggered when setItems is called

I switched from 6pac SlickGrid to your repository to use the fixedColumn functionality. A custom editor which worked with the 6pac SlickGrid broke during this switch.
I was getting an Uncaught TypeError: this.updateRow is not a function at slickgrid2\dist\grid.js:3385 .

I have traced down the error to the method SlickGrid.commitCurrentEdit (slickgrid2\dist\grid.js:3407). The problems are the execute and undo functions inside the editCommand object. When these functions are executed, this refers to the editCommand object but in the call this.updateRow(this.row) the first this must be the SlickGrid object.

I have attached a fixed version which I include in addition to your code.
const SlickGrid = require('slickgrid2').SlickGrid;
require('./slickgrid.editor.fix.js')(SlickGrid);

slickgrid.editor.fix.js.txt

slickgrid fetches a metadata object for rows using:

dataView.getItemMetadata(row)

which returns a metadata object with the following shape:

rowMetadata =
  formatter: Function
  selectable: Boolean
  focusable: Boolean
  columns:
    columnIdA:
      formatter: Function
      selectable: Boolean
      focusable: Boolean
    columnIdB:
      formatter: Function
      selectable: Boolean
      focusable: Boolean
    ...
...

Currently, if the top-level formatter or selectable values are set in rowMetadata, slickgrid returns early and doesn't allow us to override these values with the formatter or selectable values defined in the columns object.

This PR gives slickgrid a more sensible inheritance model: columnMeta > rowMeta instead of rowMeta > columnMeta.

And get rid of ones that don't apply to this version anymore (e.g. deferred loading)

Currently, slickgrid instantiates with Slick.GlobalEditorLock, which is an instance of Slick.EditorLock

This works fine for a single grid, but breaks down when multiple editable grids are on the same page.

1. Create a grid where the first column is not focusable
2. Use arrow keys to arrow all the way right
3. Arrow all the way left

Expected: At the end, the grid should be scrolled all the way left, and the unfocusable column should be completely visible

Actual: Unfocusable column is not visible

onRowsChanged isn't guaranteed to fire when filtered items change.

Add an explicit event onFilteredItemsChanged event to capture this.