GithubHelp home page GithubHelp logo

danielamitay / daappsviewcontroller Goto Github PK

View Code? Open in Web Editor NEW
466.0 466.0 86.0 1.2 MB

DAAppsViewController is a simple way of displaying apps from the App Store in an aesthetically similar manner.

License: Other

Objective-C 97.11% Ruby 2.89%

daappsviewcontroller's People

Contributors

conis avatar coryalder avatar danielamitay avatar ricsantos avatar vinceyuan avatar vitoziv avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

daappsviewcontroller's Issues

suggest switch url to https://

to compliance with apple's ATS.
from
[requestUrlString appendString:@"http://itunes.apple.com/"];
to
[requestUrlString appendString:@"https://itunes.apple.com/"];

Added languague to app store data fetch

I´m not shure how to make a commit, so I´ll leave my tip here instead :-)

I have different names for my apps in different languages and was only seeing us names in my list by artist id. After changing lines 99 to 108 in DAAppsViewController.m from:

NSString *countryCode = [[NSLocale currentLocale] objectForKey:NSLocaleCountryCode];
NSMutableString *requestUrlString = [[NSMutableString alloc] init];
[requestUrlString appendFormat:@"http://itunes.apple.com/"];
if (countryCode)
{
[requestUrlString appendFormat:@"%@/", countryCode];
}
[requestUrlString appendFormat:@"artist/id%i", artistId];
[requestUrlString appendFormat:@"?dataOnly=true"];
NSURL *requestURL = [[NSURL alloc] initWithString:requestUrlString];

to this:

NSString *countryCode = [[NSLocale currentLocale] objectForKey:NSLocaleCountryCode];
NSString *languagueCode = [[NSLocale currentLocale] objectForKey:NSLocaleLanguageCode];
NSMutableString *requestUrlString = [[NSMutableString alloc] init];
[requestUrlString appendFormat:@"http://itunes.apple.com/"];
if (countryCode)
{
[requestUrlString appendFormat:@"%@/", countryCode];
}
[requestUrlString appendFormat:@"artist/id%i", artistId];
[requestUrlString appendFormat:@"?dataOnly=true"];
[requestUrlString appendFormat:@"&l=%@", languagueCode];
NSURL *requestURL = [[NSURL alloc] initWithString:requestUrlString];

my "apps by artist id" list now contains localized app names (by current region, not preffered language)

edit: this allso makes sure you only show apps available in users region.

Thread 1: EXC_BAD_ACCESS

DAAppsViewCell.m

self.nameLabel.text = appObject.name; //Thread 1: EXC_BAD_ACCESS (code=1, address=0x25b8bbec8)
self.genreLabel.text = appObject.genre;
[self.purchaseButton setTitle:appObject.formattedPrice forState:UIControlStateNormal];

Block list option for loadAppsWithArtistId

Hi, thanks for providing the awesome library.

I use loadAppsWithArtistId in the settings of my apps, but it would be great if I can add some block ID list with that.

In this case, you can disable showing the current app you are using with the loadAppsWithArtistId method, and you can also disable some apps you don't want to show.

It's convenient for me to use loadAppsWithArtistId instead of loadAppsWithAppIds since I don't need to update my old apps to show brand new apps in the "Other Apps" section of settings.

App icons are blank from iOS9

Hi, I like this library very much, but from iOS9, it seems that all app icons are not displayed properly, they are all blank icons now. Any way to fix it?

framework target

not really an issue, more of a feature request.
it would be nice if there was a cocoa touch static library target. then the project could be easily added as a dependency of another non-arc project without having to add compiler flags.
maybe there could be a single .xcodeproj with an examples target as well?

cheers
Andrew

Is there any way to show it with present modally?

Hi, showing DAAppsViewController with pushViewController worked perfectly well. But because of our current UI design, I am wondering if there is a way that I can show it with present modally?

Thank you

Adding this to a project in storyboard

Quick question on this, can anybody tell me how to add this to my project? i want it on page 5 in Storyboard mode but this code only loads up on the main page and the project does not include an xib or storyboard as they are not needed

Any idea anyone?

App Bundles not returned for an artistid lookup

When I use this URL with proper User-Agent, resulting JSON does not include app bundles.

https://itunes.apple.com/lookup?id=XX&entity=software

Anyone knows what should be added/changed? When using this in Safari, it shows the bundles, thus I think this is due to User Agent string. What's the correct one..?

Error of running example

* Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '* -[NSURL initWithString:relativeToURL:]: nil string parameter'

below code produces an error

ifdef __IPHONE_8_0

    if (&SKStoreProductParameterAffiliateToken) {
        if (self.affiliateToken) {
            [appParameters setObject:self.affiliateToken forKey:SKStoreProductParameterAffiliateToken];
            if (self.campaignToken) {
                [appParameters setObject:self.campaignToken forKey:SKStoreProductParameterCampaignToken];
            }
        }
    }

the above code produces a warning
'address of skstoreproductparameteraffiliatetoken will always evaluate to true

how to silence this warning?

Can't make purchase using SKStoreProductViewController. Apple Store Purchase works.

Hi,

I am using DAAppsViewController in my project and using iPAD Mini device (iOS 8.3) for testing. It is showing all of my apps and launching SKStoreProductViewController. When I try to make a purchase then it asks to sign in with APPLE id. I am using my existing APPLE id with correct password (tried several times) but I am always getting following error

"The Apple ID you entered couldn't be found or your password is incorrect"

But when I click on "Store" at the Top right corner and try to make a purchase directly on APPLE STORE using the SAME Apple id and password then it always works. But in that case, I had to live my app while I need in-app store purchase without leaving my app.

I am just not sure that SKStoreProductViewController is working or not. Can you purchase and download an app using SKStoreProductViewController on a device that has ios 8.3+ version? Can you please check and confirm that it is working on any ios version greater than equal to ios 8.3?

My Apple id belongs to INDIA Store and valid for purchases in INDIA. I have seen in your code that it is not restricted to US Only so it should work in INDIA store if it is working for US Store.

Does it only work for an apple id that is valid for purchases in US APPLE STORE?

I tried changing my iPad setting by setting Country= USA and language = US English but it still doesn't work with my apple id as it is valid for INDIA store. I didn't create a new apple id for US store as I think it is against the iTunes policy to use multiple accounts.

How am i supposed to fix this issue?

If it is not working on new iOS versions then please fix this issue. If it is somehow restricted to US only purchase then please add in-app app purchase functionality for other countries too.

Please reply.

Thanks.

Bundle problem when using with cocoapods and useframeworks

When using this library with cocoapods and enabling use_framewors! the bundled resources can't be accessed. This leads to a crash in the DAAppViewCell (line 58) since it's trying to insert nil.

I think the following code:

UIImage *starsImageSheet = [UIImage imageNamed:@"DAAppsViewController.bundle/DAStarsImage"];

has to be changed to something like:

NSBundle *bundle = [NSBundle bundleForClass@"DAAppsViewController"];
// and then use something like
UIImage *starsImageSheet = [UIImage imageNamed:@"DAStarsImage"e inBundle:bundle compatibleWithTraitCollection:nil];

The Problem is described here.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.