danieldg / rwaybar Goto Github PK

This would replace:

git clone https://github.com/danieldg/rwaybar
cd rwaybar
cargo build --release
cp target/release/rwaybar <somewhere>
cp doc/rwaybar.toml ~/.config/
$EDITOR ~/.config/rwaybar.toml

with:

cargo install rwaybar
rwaybar  # generates example config if it does not find a config
$EDITOR ~/.config/rwaybar.toml

• To support cargo install rwaybar needs to be published on crates.io
• Since we do not clone the repo anymore rwaybar needs to generate the config. A simple const CONFIG: &str = include_str!(doc/rwaybar.toml) combined with a fs::write_all(config_path, CONFIG.as_bytes()) when the config is not found should do the trick.

----------------------- Edit ----------------------
I just realize I can also use cargo install --git https://github.com/danieldg/rwaybar. However I still think it would still be nice to have this on crates.io.

As of Pop-os 22.04 is using Pipewire instead of Pulseaudio. While pipewire should be backwards compatible rwaybar no longer shows the volume as of Pop-os 22.04. Most distros plant upgrade to upgrade to pipewire sometime in the future.

As a first step I think rwaybar would need a clear API for the audio back-end. Then the first implementation could use a compile time feature to switch between implementation. Later it could be auto detected.

An alternative would be figuring out why the volume is not shown on Pipewire even though it should be backward compatible.

Hi!

Would you consider publishing pulse_tokio module on crates.io? Or maybe it would be possible to upstream it?

Thanks!

Hi, I am trying to learn how to produce graphics through wayland/wlroots.

I want to get started on how do I like produce graphics on wayland, like what should I do, can I please be given the bare minimal to start on?

Hi there, first of all thanks for building a fast zero dependency Wayland compatible bar with excellent documentation in the wiki.

When I started using rwaybar I copied the default config however I then got greeted by less then ideal errors (mostly Error: Os { code: 2, kind: NotFound, message: "No such file or directory" } ). By eliminating most of the config I quickly found out it was due to incorrect font paths.

I think rwaybar could be made easier with better error handling. In the source I saw you bubble errors up using Box<dyn Error>. I have found color_eyre a wonderfull (drop in!) replacement for that. It would make it easy to add context to an error such as the one above.

For example the font not found line:

could become:

use color_eyre::{Result, eyre::WrapErr};
pub fn new(name: String, path: PathBuf) -> Result<Self> {
    let file = File::open(&path)
        .wrap_err_with(|| format!("Could not open font {name} at given path {path:?}"))? 

I stumbled upon this project through GitHub and am very happy to see a bar that doesn't depend on gtk. The name, to me, just doesn't roll of the tongue well. I have some suggested names wraybar, raybar, or rubar. This is just a suggestion and not a really productive one. (I don't know rust)