Favorites.java:35-37: Provide RtFavorites implementation... about versioneye-api

[SherifWaly]

@amihaiemil Ok, I would like to do it :D

[amihaiemil]

@SherifWaly Well, for Comments it is mandatory to specify the page number (Comments.fetch(int page)). I imagine it should be the same for Favorites. If they have no clue what page to mention, I think it is intuitive that "1" should work :D And if they specify a negative number or whatever, it will crash most likely, but that's none of our business -- we are not supposed to pollute our code with validations for all sorts of user scenarios, I think.

[amihaiemil]

@SherifWaly thanks :)

[0pdd]

@amihaiemil please pay attention to this new issue.

[amihaiemil]

@SherifWaly Want to do this? I think it should be very similar to the way RtComments and RtComment are implemented. You can puzzle out the unit and integration testing :D

[amihaiemil]

@SherifWaly Here is how /favorites looks like (user datamd):

{
  "user": {
    "fullname": "datamd",
    "username": "datamd"
  },
  "favorites": [
    {
      "name": "doctrine/common",
      "language": "php",
      "prod_key": "doctrine/common",
      "version": "2.7.2",
      "prod_type": "composer"
    },
    {
      "name": "doctrine/doctrine-module",
      "language": "php",
      "prod_key": "doctrine/doctrine-module",
      "version": "2.0.0",
      "prod_type": "composer"
    },
    ...
  ],
  "paging": {
    "current_page": 1,
    "per_page": 30,
    "total_pages": 3,
    "total_entries": 70
  }
}

[amihaiemil]

And as I see, a project shows up as "favorite" if you follow it :)

[SherifWaly]

@amihaiemil What should happen if the page number isn't provided ?
Also for the paging part I see that there is the same puzzle for Comments.

[0pdd]

The puzzle 11-51606277 has disappeared from the source code, that's why I closed this issue. //cc @amihaiemil