GithubHelp home page GithubHelp logo

Comments (9)

amihaiemil avatar amihaiemil commented on June 5, 2024 1

The jsonobject builder, the "storage", will be passed through all the mkclasses, just like an http request is passed in the real ones. And each class will add a json object or array in it, or read something from it.

from versioneye-api.

amihaiemil avatar amihaiemil commented on June 5, 2024 1

Well, you could do MkMe? :D open an isue for it and I'll assign it to you :)

from versioneye-api.

0pdd avatar 0pdd commented on June 5, 2024

@amihaiemil please pay attention to this new issue.

from versioneye-api.

SherifWaly avatar SherifWaly commented on June 5, 2024

@amihaiemil Each of Users, Organizations, ... etc should be passed a MkServer object which is built in the unit test for example. Is that right or I'm missing something :D ?

from versioneye-api.

amihaiemil avatar amihaiemil commented on June 5, 2024

@SherifWaly Good question. Well, normally, we should also have POST methods, but as you see the API doesn't have many of those... most of them are only for GETting information from the server, not sending.

So it's going to be either as you said, or I think we could add POSTs on the interfaces (even if they are not yet available in the actual API) and the real implementations will throw UnsupportedOperationException :D Makes sense?

When testing, it would be something like this:

VersionEye versioneye = MkVersionEye();
versioneye.me().comments().post(...)//add the comment to the JSON structure
//..test code here

And if versioneye above would happen to be a real RtVersionEye then the post(...) method would throw the exception since there is no real endpoint to call yet. (well actually, the post method for comments would be on a Project interface somehow but nevermind :) )

from versioneye-api.

SherifWaly avatar SherifWaly commented on June 5, 2024

@amihaiemil Yes, I think I understand your idea :D
Just I want to note that for example Teams consists of JsonArray not JsonObject so would that conflict with MkServer as storage() returns only JsonObjectBuilder and no JsonArrayBuilder?

from versioneye-api.

amihaiemil avatar amihaiemil commented on June 5, 2024

@SherifWaly no, because the JsonObjectBuilder of MkServer will contain everything. It will be the parent of all sub-jsons (think of it as of a tree). So when you add a JsonArray of teams, it will be part of the big json object :D

from versioneye-api.

SherifWaly avatar SherifWaly commented on June 5, 2024

@amihaiemil Yes, I understand it now thank you for elaborating :D
Could you assign me a sub-task which is somehow easy so that I would understand it better by implementing :) ?

from versioneye-api.

0pdd avatar 0pdd commented on June 5, 2024

The puzzle 13-64d6efce has disappeared from the source code, that's why I closed this issue. //cc @amihaiemil

from versioneye-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.