GithubHelp home page GithubHelp logo

Comments (6)

domenic avatar domenic commented on June 14, 2024

I think this is actually a case for the Client Credentials flow. In particular, compare the ASCII-art diagram there with the one for Resource Owner Password Credentials.

Interestingly enough, CC is very simple and is a clear subset of ROPC. So it would be pretty easy to implement as part of restify-oauth2.

Maybe the API should be that you provide either hooks.grantClientToken, for CC, or you provide hooks.validateClient and hooks.grantToken, for ROPC? What do you think of an API like that?

from restify-oauth2.

rpedela avatar rpedela commented on June 14, 2024

Makes sense, and yes I like that API. Thanks for planning to add it. My only suggestion is to add something to the API which makes it clear you are using CC or ROPC, but it is a pretty simple thing to documentation as well.

from restify-oauth2.

domenic avatar domenic commented on June 14, 2024

Yes, I was wondering about that. Ideas appreciated. Here are some random ones that I'm not sure if I like:

restifyOAuth2.ropc(server, options); // hooks = existing ones
restifyOAuth2.cc(server, options);   // hooks = grantToken, authenticateToken
var options1 = {
  tokenEndpoint: "/token",
  ropcHooks: { validateClient, grantToken, authenticateToken }
};

var options2 = {
  tokenExpirationTime: 3600,
  ccHooks: { grantToken, authenticateToken }
};

from restify-oauth2.

rpedela avatar rpedela commented on June 14, 2024

Functions allow you to know what the user's intentions are which is useful for checking that the right hooks were given. Also the API is clear if more flows are added in the future since the options could be very different.

from restify-oauth2.

domenic avatar domenic commented on June 14, 2024

Version 2.0.0 is now out, with support for the client-credentials flow!

from restify-oauth2.

rpedela avatar rpedela commented on June 14, 2024

Awesome! Thanks.

from restify-oauth2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.