Doesn't seem to work with module marked as external about rollup-plugin-includepaths

[darlanalves]

Hello guys! Sorry for the super late response.

So, from what I know so far about rollup, it goes through the list of modules included and pass their names down the chain of plugins to be resolved.

@Narretz:
The purpose of this plugin is to simplify the inclusion of modules from paths relative to one or more base paths. In your case, it would not be a relative resolution, but a node module instead. If you don't use another plugin to include node_modules folder, it will be marked as external and left out of the final bundle.
That being said, the include option is a bypass of the entire plugin code, pointing a module name directly to a file path. I don't know exactly why your module is being marked as external, it should be included in the bundle as well.
I think a better approach in this case would be a removal of your include option here and add the https://github.com/rollup/rollup-plugin-commonjs plugin in your setup to add node modules.

@adriengibrat:
Thanks for your PR. I'm adding it to the plugin 👍

[adriengibrat]

same here, option.include seems broken since #3 has changed cache key structure...

But for your particular issue, if foo is in node_modules, it is an external dependency, so you don't really have to use include option ;)

[adriengibrat]

Great, thanks for the merge!

Could we expect a release including the bug fix ?
I hope a 0.1.6, unless you have more to add.

P.S. I've payed lately with npm commands, i discovered you can :

• hook in npm version with scripts in package.json since [email protected] :

"engines": {
  "npm": ">= 2.13.2"
},
"scripts": {
  "postversion": "git push && git push --tags"
},

• pass commit message to npm version

npm version patch -m "%s include option won't treat included dependencies as external dependency"

• npm deprecate bugged releases:

npm deprecate rollup-plugin-includepaths@"0.1.3 - 0.1.5" "v0.1.6 fix issue with include option"

• make range expression like a pro with https://semver.npmjs.com ;)

[darlanalves]

Fixed with release 0.1.6 (#11). Closing the issue.